search

godotengine / godot-demo-projects

Demonstration and Template Projects
https://godotengine.org
MIT License
5.92k stars 1.65k forks source link

Upload 4.x demos to the asset library #920

Open diguifi opened 1 year ago

diguifi commented 1 year ago

Which demo project is affected: godotengine/godot-demo-projects/tree/master/3d/platformer

OS/device including version: _

Issue description: The project is tagged as 3.5 at the asset store, when it has been updated to version 4 recently. I think this is an important matter since I and many others have been targeting v4 only on the asset store.

Screenshots of issue: image image

Calinou commented 1 year ago

The 4.0 demos aren't uploaded to the asset library yet. Note that some demos weren't ported to 4.0 yet, so not all 3.x demos have a working 4.0 counterpart yet.

Calinou commented 7 months ago

As per the tracker, there are still a few demos pending an update so we can upload all 4.x demos at once on the asset library. These can prove to be difficult to update in a fully functional manner, so maybe it's better to upload what works now and upload the rest later once they're ported. I'll look into doing this at some point.

Calinou commented 7 months ago

All 4.2 demos are now on the asset library, with a few exceptions as these demos are currently not functional in the master branch:

mhilbrunner commented 6 months ago

The HDR demo likewise seems to be missing. Should we update the descriptions of the outdated 3.x entries on the Asset Lib to link to the 4.x versions?

Calinou commented 6 months ago

The HDR demo likewise seems to be missing. Should we update the descriptions of the outdated 3.x entries on the Asset Lib to link to the 4.x versions?

It's called Glow for 2D in 4.x as it no longer relies on HDR (since HDR in 2D was removed in 4.0 and only reimplemented in 4.2).

The demo will eventually be updated to optionally use HDR in 2D, but we can't make it a hard requirement of the demo as HDR in 2D isn't available in the Compatibility rendering method.