search

godotengine / godot-demo-projects

Demonstration and Template Projects
https://godotengine.org
MIT License
5.74k stars 1.59k forks source link

Port demos with remade art assets to Godot 4 #922

Closed Calinou closed 7 months ago

Calinou commented 1 year ago

This re-ports the following demos to Godot 4 following their latest 3.x versions:

Some tweaks have also been made in the process, such as split screen players having different colors in the 2D Platformer demo.

I'm having trouble porting the 2D JRPG demo due to AnimationTree stuff I'm not proficient with. Could someone lend a hand? Edit: Fixed by https://github.com/Calinou/godot-demo-projects/pull/3. Thanks @Nonparoxysmic!

Preview

navigation_astar webp

isometric webp

platformer webp

jtnicholl commented 1 year ago

The existing 4.0 version of the 2D platformer included cleaned up scripts, reorganized files, and improved controls. I'd prefer not to have that all be undone.

Calinou commented 1 year ago

The existing 4.0 version of the 2D platformer included cleaned up scripts, reorganized files, and improved controls. I'd prefer not to have that all be undone.

I don't see an easy way to merge both. Redoing all the tiles and animations from scratch by basing myself on the 4.0 demo would be too much work.

I can try to replicate the new file structure and port some script changes from the 4.0 demo still.

Edit: Done.

zf-moth commented 1 year ago

I'm having trouble porting the 2D JRPG demo due to AnimationTree stuff I'm not proficient with. Could someone lend a hand?

@Calinou Do you still need help with that? Or is it finished?

Calinou commented 1 year ago

@Calinou Do you still need help with that? Or is it finished?

I still need help with that, and won't have time to work on this in the near future. Please look into it if you can – it'll be very appreciated :slightly_smiling_face:

Edit: See https://github.com/Calinou/godot-demo-projects/pull/3.

Calinou commented 11 months ago

This should be good to merge thanks to @Nonparoxysmic's work :slightly_smiling_face:

Calinou commented 7 months ago

I've retested all demos on 4.2.1 and saved them again, with no warnings occurring when you run the projects.

I've fixed the JRPG demo UI theme (and have also increased font sizes to match the rest of the UI):

image

image

However, there's an issue with the navigation demo I get since 4.1. Nothing happens when I click on empty space on the TileMap, and I get this error:

ERROR: Can't get id path. Point (0, 0) out of bounds [P: (1, 1), S: (16, 8)].
   at: get_point_path (core/math/a_star_grid_2d.cpp:492)

Edit: I fixed the navigation AStar issue. It was caused by get_used_rect() not working anymore on TileMap, so I manually specified the size which is also more predictable in this demo.

smix8 commented 7 months ago

Tested the 4 demos: