godotengine / godot-demo-projects

Demonstration and Template Projects
https://godotengine.org
MIT License
5.65k stars 1.58k forks source link

Example of "webrtc_signaling" not working on the web #983

Closed satoshidisciple closed 10 months ago

satoshidisciple commented 10 months ago

Which demo project is affected:

OS/device including version:

Issue description:

To test, simply configure export for the Web. Run node_server and run the project.

When executed by the editor, everything will work normally, but if you try to run it in the Browser the connection will not be established.

I investigated the problem and apparently the error is in performing "ws.get_ready_state" before "ws.pool" in the browser;

I created a PR fixing the bug: https://github.com/godotengine/godot-demo-projects/pull/982

satoshidisciple commented 10 months ago

My fix merge request was accepted, so I think you can now close this issue. Thank you

aaronfranke commented 10 months ago

@satoshidisciple Issues should not be closed until after the PR is merged. Also, you can ensure these things happen at the same time by adding "Fixes #983" in the PR description. I've went ahead and done this for you.