godotengine / godot-docs-l10n

Localization of the Godot documentation – Translations should be done on Weblate (see link)
https://hosted.weblate.org/projects/godot-engine/godot-docs/
Other
53 stars 39 forks source link

String replacement in property name processor breaks translation lookup #23

Closed Cerno-b closed 11 months ago

Cerno-b commented 11 months ago

In the editor_property_name_processor.cpp, there are some property substrings that are automatically modified for display in Godot's settings. Unfortunately, this replacement seems to break translation lookup.

Case in point:

I assume that since the name gets modified from Usec to µsec, it can't be found by the translation and will remain untranslated.

image

timothyqiu commented 11 months ago

It was because our code style was changed from using String::utf8("XXX") to U"XXX", but the extraction script did not catch that.

This is fixed in https://github.com/godotengine/godot-editor-l10n/pull/10. Weblate will be fixed on next sync.

Cerno-b commented 11 months ago

Nice!