tetrapod00
commented
3 days ago Hi! Thanks for your interest in contributing. I can't answer all the questions about Line2D specifically, but as for your general questions:
Is the above reasonable to expect from the documentation?
Maybe, though the class reference tries to be concise and so sometimes leaves details like this out. I think if you can find a good general and concise way to communicate the behavior it could be a good addition.
Is the reason it is not there already is due to massive nature of documenting everything?
Very likely! There is always more work to be done in documentation, as you can see by the 800+ open issues we have here.
It would be helpful for me to make an update and do a pull request?
Yes, though I should say up front that it may need some revisions, and not every PR ends up merged for various reasons (I personally have several docs PRs stuck in review in the main repo). One thing that can make it easier to review is to provide some examples of what you tested, or possibly even an MRP demonstrating the behavior.
Changes to the class reference are made in the main repo, not here, and we have a tutorial for it here: https://docs.godotengine.org/en/stable/contributing/documentation/updating_the_class_reference.html. Even though you would be editing the main repo, you're not changing C++, just XML files.
Are examples desired as above, or just the technical detail?
Examples are okay but ideally you can also find a way to describe the general behavior, and use the examples to clarify the general behavior.
Is it a bug that I must toggle visibility to update, or reasonable to expect and perform when making these sorts of changes.
I'm not familiar with the details of this class, but that sounds like a bug to me. There are a few longstanding bugs that might as well be intended at this point, though. See if you can find a related issue in the main repo, and if not, feel free to report it.
I do see that you listed 4.2.2 as your version, so you might check 4.3 and see if its improved at all. Also, if you're documenting things, iyou should probably test the behavior on at least 4.3, and maybe a 4.4 dev version.
I hope that answers your questions, feel free to stop by in the docs channel of the contributors chat if you have any more.
runningopenloop
Your Godot version: v4.2.2.stable.official [15073afe3]
Issue description: Details on how texture mapping works with Line2D.
URL to the documentation page (if already existing): https://docs.godotengine.org/en/stable/classes/class_line2d.html
I thought clarification/details on how the texture maps to the Line2D given settings is in order.
When using the "width curve", the width_curve value appears to be a multiplier to the width specified in pixels for actual width of line as interpolated along.
When making a change to the texture width (or other settings), you may need to toggle visible off/on to see update.
As for texture mapping to line. These results were obtained using a 2D Linear Gradient Texture.
Therefore, it seems for texture mapping the line. The height of texture relates to the width of line. Wrapping of the "U" coordinate will happen at TEXTURE_WIDTH / TEXTURE_HEIGHT * LINE_WIDTH (in pixels).
It strikes me this sort of documentation would be helpful to know how to use the Line2D. Is the above reasonable to expect from the documentation? Is the reason it is not there already is due to massive nature of documenting everything?
It would be helpful for me to make an update and do a pull request? Are examples desired as above, or just the technical detail?
Is it a bug that I must toggle visibility to update, or reasonable to expect and perform when making these sorts of changes.