search

godotengine / godot-docs

Godot Engine official documentation
https://docs.godotengine.org
Other
3.91k stars 3.2k forks source link

Change color of the sidebars's scrollbar #3424

Open groud opened 4 years ago

groud commented 4 years ago

Your Godot version: Latest documentation

Issue description: Recently, a scrollbar was added (or it's color changed) to the latest documentation. However, the color selected (a red similar to the one of the logo) really grabs the attention too much. 2020-04-21-103931_1107x330_scrot

This color is supposed to emphasis things, that's why it make sense to use it for the titles in the sidebar. However, I don't think grabbing the attention to a scrollbar make a lot of sense.

I suggest we change the scrollbar color to something darker / less attention grabbing. Something like this maybe (but any other less emphasizing color will do :) ):

improved

URL to the documentation page (if already existing): https://docs.godotengine.org/en/latest/

YuriSizov commented 4 years ago

I am biased, as I was the one to work on that scrollbar, but I like contrast here more than your suggestion. It was dimmed after the initial implementation was rolled out because it was too eye catching. It's much calmer now. Though I use the dark theme, so maybe the light one requires some tuning.

I don't think that the scrollbar itself grabs attention a lot. I'd argue, that the fact that the main content is not centered is the main annoyance here. Something like #3139 would be a better way to deal with the situation.

groud commented 4 years ago

I don't think that the scrollbar itself grabs attention a lot.

Well, to give a little bit of context, I haven't opened the latest version of the docs in a while, and this is the first thing I noticed when opening the docs. So, yes, it is grabbing attention, at least for me.

I like contrast here more than your suggestion. It was dimmed after the initial implementation was rolled out because it was too eye catching. It's much calmer now. Though I use the dark theme, so maybe the light one requires some tuning.

IMHO, that's typically the place where we don't want too much contrast. Indeed the scrollbar should be visible, but the emphasis is too strong here. I have rarely seen a scrollbar with a completely different hue of its background in any software. We could go for a color different from my suggestion, I don't mint, whatever standing out less would be good to me.

But anyway, that's more like a suggestion. I opened an issue to see if other people agree with me. Maybe I am the only one having a problem with this color, let's see. :)

Calinou commented 4 years ago

How about a translucent white scrollbar with a transparent background? This would mimic the scrollbar look found in some applications when using a dark theme (including Godot).

YuriSizov commented 4 years ago

Sure, we can go with light gray and white. Be gentle with the transparency, though, as mixing it with a blue background may make it too colorful again. The dark theme is going to be okay, but the light one needs careful consideration.