godotengine / godot-docs

Godot Engine official documentation
https://docs.godotengine.org
Other
3.87k stars 3.16k forks source link

"Your first 3D game" issues #6744

Open andreymal opened 1 year ago

andreymal commented 1 year ago

There's a bunch of weird things I ran into while trying to follow the "Squash the Creeps" tutorial in Godot 4. I'm not a Godot expert and don't know how to fix some of these things, so I don't want to make a pull request, but I hope this list can help other contributors improve the documentation.

Common

The screenshots are inconsistent:

Perhaps it would be a good idea to recreate all the screenshots after the first release candidate?

Your first 3D game

Setting up the game area

By the way: unlike Godot 3, the ground is not white in Godot 4. Can we tweak something to make the lighting identical to Godot 3?

Player scene and input actions

Moving the player with code

Designing the mob scene

Spawning monsters

Jumping and squashing monsters

Killing the player

Score and replay

Character animation

P.S. I didn't test C#

skyace65 commented 1 year ago

I'll go over this on Friday and work on a PR for it. And keep in mind, even if you can't fix everything on this list there's nothing wrong with making a PR fixing only what you do know how to fix.

DigitalBox98 commented 1 year ago

A comment on the C# part : to make things work, you will need to update some properties with the first letter changed to uppercase like below : direction.x += 1f; => direction.X += 1f;

citrusmunch commented 1 year ago

09.adding_animations.rst:261

Here I managed to use the Edit button on the top right to Copy Tracks and Paste Tracks. I had to use Animation > New for the Edit button to be available for pasting in the mob animation player.

citrusmunch commented 1 year ago

09.adding_animations.rst:261

Here I managed to use the Edit button on the top right to Copy Tracks and Paste Tracks. I had to use Animation > New for the Edit button to be available for pasting in the mob animation player.

Also noticing it should mention:

Julian-Vos commented 1 year ago

Thanks for making this list! I found another problem in "Setting up the game area" today: it says "hold the Ctrl key down to turn on grid snapping (Cmd on macOS)", but it's Ctrl on macOS as well.

Julian-Vos commented 1 year ago

Another one in "Designing the mob scene": "This function destroy the instance it's called on" should say "destroys". (oh and the method name in the code example directly below that is outdated)

MORGAN-DMG commented 1 year ago

Heyo! I actually have a fix/solution for one of the listed issues. I came across this exact issue when completing the tutorial. I apologize if this is completely out of etiquette or missing some kind of formatting. I'm very new to Godot, for reasons we all know I'm sure, and I'm fairly new to Git because again...Source Control features were handled in-engine in my previous experiences. Here's the issue I'm referring to:

==================================================== 09.adding_animations.rst:261

Next, click on Animation > Copy.

This menu doesn't exist in Godot 4. It seems we should use Animtion > Manage Animations, but I'm not sure.

====================================================

I digress! Point is, I'm fairly certain that I know how to solve this issue for the Character Animation section of this tutorial. I tried every, other way I could think of for a fix, but this method was the only one I had any success with in Godot 4.1. So, to get the animation to "Copy over," for use in the Mob class I had to:

  1. Select Player Scene
  2. Select Player Node
  3. Select the AnimationPlayer node in the Player node.
  4. With the Animation Panel open, Click on the Tool Button for "Animation"
  5. Choose Manage Animations
  6. Save the unsaved Global Library, which includes the developer created "float," animation within
  7. SIDE NOTE: I saved the Global Library as "AnimLib," to be a little more familiar with Unity's old school naming conventions
  8. Close the Edit Animation Libraries screen with the "OK" button
  9. Select/Open the Mob Scene
  10. Select the Mob Node
  11. Create a AnimationPlayer Child Node for Mob and Select it
  12. In the Animation Panel, again Click on the Tool Button for "Animation"
  13. Choose Manage Animations
  14. This time, Load Library and choose the "AnimLib," library which should be available along with the dev created "float," animation.
  15. The last step of, "make sure that the button with an "A+" icon (Autoplay on Load) and the looping arrows (Animation looping) are also turned on in the animation editor" works perfectly fine as-is.

Again, I apologize if this is the wrong way to suggest a fix, like I say I'm pretty new to both of these communities, but I hope this helps nonetheless!

seankao31 commented 11 months ago

Linking a relevant issue for copying animation here for the sake of visibility: https://github.com/godotengine/godot/issues/60848

seankao31 commented 11 months ago

Additional issue on character animation: https://github.com/godotengine/godot-docs/blob/971c1f73e74b6c8c609977355e92857f46a3df0e/getting_started/first_3d_game/09.adding_animations.rst?plain=1#L278 I believe the intention isn't integer division, but instead float division

ParadoxV5 commented 10 months ago

Setting up the game area

godotengine/godot-demo-projects#884 for Godot 4 has superceded godotengine/godot-3d-dodge-the-creeps (just opened godotengine/godot-3d-dodge-the-creeps#14 a few minutes ago). We better also rewrite the tutorial to go off the godotengine/godot-demo-projects entry instead of the outdated and unmaintained repo.

docrinehart commented 8 months ago

09.adding_animations.rst:261

Here I managed to use the Edit button on the top right to Copy Tracks and Paste Tracks. I had to use Animation > New for the Edit button to be available for pasting in the mob animation player.

Also noticing it should mention:

  • animation length needs to be adjusted to 1.2 seconds
  • remember to enable Autoplay on Load and Animation Looping

Using Godot 4.2.1.stable

I ran into this issue and considered the "Manage Animations" option, but the "Edit -> Copy Tracks" seemed more straightforward and clear to me, noting that you still have to add the AnimationPlayer on the Mob scene, so that's the approach I took to make it through.

That said, I additionally encountered a couple other interesting problems I'm not seeing referenced (just on quick searching through GitLab issues). Both are related to the character animation section:

GodotShadows_1 GodotShadows_2

skyace65 commented 7 months ago

I've updated the list with the fixes from #8955. I'll be working on a PR to fix the remaining ones. This will take several days.

artisteacher commented 7 months ago

I also noticed that the shortcut for "Duplicate" in the tutorial is just listed as shift+D - but on macOS it's actually CMD+D

floriancaro commented 4 months ago

I just finished the tutorial and noticed that the stable version is still lacking several improvements mentioned in this thread (including the "Copy Animations" part that seems to trip up a lot of people). Is it too early to push some of these updates to the stable release? (Also, thanks for all the work that went into this 🙏 )

AThousandShips commented 4 months ago

They are marked for cherry picking but haven't been processed yet, they will in some sweep