Open timothyqiu opened 1 week ago
I'm in favor of this! One thing to consider is that the banners at the top of the page already take up a large chunk of space, and another banner only adds to that. Quick mockup with inspect element, on my default firefox browser at 100% zoom on a 1080 display:
This is the worst case scenario, with a tall "latest" docs banner and 3 paragraphs in the translation banner.
The language switcher on the bottom left is hardly discoverable for users not familiar with ReadTheDocs, as it's hidden by default.
I think it would benefit more users if we do some detection and provide the option to redirect to the user's preferred language on the docs page. For example, visiting https://www.adobe.com/ might prompt you with a similar dialog if your browser's preferred language is not English.
I'm not sure if ReadTheDocs/Sphinx actually allows implementing this. But if it does, the logic might be something like this:
Accept-Language
header to see if we provide a version that matches the user's preferred language.See also https://github.com/godotengine/godot-proposals/issues/10538