search

godotengine / godot-git-plugin

Git implementation of the VCS interface in Godot
MIT License
720 stars 75 forks source link

Address issue #172, to use public key path if present in preference to using password. #173

Closed markeel closed 1 year ago

markeel commented 1 year ago

This fix simply changes the use of SSH credentials to be conditional based on the presence of SSH credentials in the Credentials object.

This lets the user specify the presence of SSH credentials if that is the desired method, or the password if that is the desired method. I tested against a repository that used SSH credentials and one that used a password.

The third method was a bit of a mystery to me, so I didn't test that option. I also do not have a Windows or Mac environment to test this in (only tested in Linux), but with only this small change it is hard to imagine what could be different.

markeel commented 1 year ago

Unfortunately I don't know how to move these checks along. What are these checks how do you run them, and how do you get a review approved?

twaritwaikar commented 1 year ago

Closing and opening to re-trigger checks