search

godotengine / godot-git-plugin

Git implementation of the VCS interface in Godot
MIT License
720 stars 75 forks source link

Add Godot 4.1 Support #198

Closed jokoho48 closed 1 year ago

jokoho48 commented 1 year ago
daveTheOldCoder commented 1 year ago

Is this update compatible with Godot 4.2 as well as 4.1? (At this time, the latest 4.2 is 4.2-dev3.)

jason-oliveira commented 1 year ago

Is this update compatible with Godot 4.2 as well as 4.1? (At this time, the latest 4.2 is 4.2-dev3.)

It does not, at least here. breaks on godot-git-plugin/src/gdlibrary.cpp:22:50: error: 'GDExtensionInterfaceGetProcAddress' does not name a type

jason-oliveira commented 1 year ago

Is this update compatible with Godot 4.2 as well as 4.1? (At this time, the latest 4.2 is 4.2-dev3.)

It does not, at least here. breaks on godot-git-plugin/src/gdlibrary.cpp:22:50: error: 'GDExtensionInterfaceGetProcAddress' does not name a type

Update: I frankenstein'd the latest godot-cpp into this PR, and it got past the build error. godot-cpp included is from 4.1 and is not compatible with 4.2.dev3.

It now breaks on not finding libssl.la

ezragoss commented 1 year ago

Just downloaded the macos universal artifact from Checks and opened the test project (as well as tried to import on a fresh project). Enabling the add on errors with

ERROR: Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'.

The check seems to have passed which is confusing. That file does indeed not exist in the artifact.

Ah nevermind - just read #183. I can now confirm the commit tab pops up and works for macos

jasonlessenich commented 1 year ago

What's the state of this? Can this already be used?

Iseeicy commented 1 year ago

^ Echoing the above, would love to be able to use this plugin

daveTheOldCoder commented 1 year ago

I briefly tested v3.0.1 of this plugin on Linux, using the .zip provided above, with Godot 4.1.2-rc1 and 4.2-dev6, and did not find any new issues.

I did have this problem, but I first encountered that with v3.0.0.

heckert-gamedev commented 1 year ago

Using: Godot v4.1.2.stable - Ubuntu 20.04.5 LTS (Focal Fossa) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Ti Laptop GPU () - AMD Ryzen 5 5600H with Radeon Graphics (12 Threads)

Downloading and importing: libgit_plugin.linux.x86_64.editor.so-c89b1f54a62707d96143ee336a3e0ee6b8ccb40e.zip

Still gives me:

  Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'.
  Failed loading resource: res://addons/godot-git-plugin/godot-git-plugin.gd. Make sure resources have been imported by opening the project in the editor at least once.
daveTheOldCoder commented 1 year ago

Still gives me: Attempt to open script 'res://addons/godot-git-plugin/godot-git-plugin.gd' resulted in error 'File not found'. Failed loading resource: res://addons/godot-git-plugin/godot-git-plugin.gd. Make sure resources have been imported by opening the project in the editor at least once.

That's not an error. That message is displayed if you attempt to enable the plugin in Project Settings. With this plugin, you don't do that.

Note: you do NOT need to manually enable the plugin in the Project > Project Settings > Plugins tab. In fact, you can't; that tab is for script-based plugins, GDExtension plugins, like this one, will be loaded automatically.

Wiki/Installation

(I think that the Godot editor needs a fix for this situation. It's confusing to users.)