godotengine / godot-git-plugin

Git implementation of the VCS interface in Godot
MIT License
697 stars 73 forks source link

Error -16 (SSH response issue) with Godot 4.2.1 Stable #215

Open sillypears opened 9 months ago

sillypears commented 9 months ago

While being able to stage/unstage and commit files without issue, pushing to and pulling from Git over SSH appears to not work for me. If I open the repository in VSCode (or from cmd line) I am able to push and pull without issue.

I setup my respos to use SSH transport and in the VCS I have added my keys. Refreshing, pulling or pushing commits causes the Godot editor to freeze for ~2 minutes (assuming this is the SSH timeout). Screenshot of the error below.

Not sure if I'm doing something wrong or if there was something I missed.

image

Calinou commented 9 months ago

Which Git host are you trying to push to? Does your SSH key use ECDSA (elliptic curve) cryptography? See https://github.com/godotengine/godot-git-plugin/issues/193.

sillypears commented 9 months ago

This is going to Github.com

It's been a while since I had created the key so I'm unsure, but it's possible that I created it with ECDSA. I know on MacOS it was giving me some issues because it was an OPENSSH generated key instead of RSA and I had to do some conversions to have the Mac even load the key. I've tried both versions of that with the plugin and both failed.

I've switched to having a 2nd remote as an HTTP origin and PAT for now. If there is any kind of debugging I can run have it the plugin show more information, I'm happy to try that out.

Mishaniz commented 7 months ago

I am encountering the same issue, trying to push to Github with an RSA key.

Herbherth commented 7 months ago

Same, using SSH doesn't seems to work. Tried with Ed25519 and RSA keys.

I've switched to having a 2nd remote as an HTTP origin and PAT for now. If there is any kind of debugging I can run have it the plugin show more information, I'm happy to try that out.

Luckily that works out for me too, thankyou, I just wish that I could have the option to save the PAT so I don't have to put it again every time I want to push something.

LaurentOngaro commented 6 months ago

same issue for me with SSH and it works fine with an HTTPS url in the git config file

unchowder commented 6 months ago

Just wanted to chime in that I experienced the same thing. SSH wasn't connecting with error -16, but an HTTPS url for the remote and a PAT for the password works.

I'm new-ish to software and mostly self-taught, so this tripped me up for a bit since I was just following the plugin documentation, which makes no mention of this issue.

Calinou commented 6 months ago

I'm new-ish to software and mostly self-taught, so this tripped me up for a bit since I was just following the plugin documentation, which makes no mention of this issue.

I've modified the wiki setup page to warn about known issues in SSH authentication.

Buczkek commented 4 months ago

I've had the same issue with the RSA key, after hours of searching for a fix I found out that the SSH key in PEM format works fine.

howardwu1 commented 4 months ago

I've had the same issue with the RSA key, after hours of searching for a fix I found out that the SSH key in PEM format works fine.

Thank you so much @Buczkek Confirmed this works for me too. Would love if the docs were changed to have this fix!

Tetriser commented 1 month ago

I still get the error even if my RSA key is in PEM format Created it using ssh-keygen -t rsa -m PEM