godotengine / godot-ios-plugins

MIT License
126 stars 48 forks source link

GameCenter Plugin award_achievement not displaying banner #13

Closed Tekuzo closed 3 years ago

Tekuzo commented 3 years ago

I am using the GameCenter plugin in my game and following the documentation I call award_achievement() from within a function that I have connected to a signal that various nodes can emit when their criteria is true.

func unlock_achievement(name):
     Singleton.award_achievement({"name": name, "progress": 100.0, "show_completion_banner": true});

When the signal is emitted the achievement is awarded because I can go and check my awarded achievements with the show_game_center( { "view": "achievements" } )) function. So the function mostly works, its just not displaying the banner.

Calinou commented 3 years ago

cc @naithar

naithar commented 3 years ago

So the function mostly works, its just not displaying the banner.

Was it working before?

I guess something goes wrong with this line https://github.com/godotengine/godot-ios-plugins/blob/master/plugins/gamecenter/game_center.mm#L166.

Tekuzo commented 3 years ago

No, it never worked to my knowledge. I just got achievements unlocking yesterday and did a bit of testing then decided to submit my bug report.

Tekuzo commented 3 years ago

I take it back, it just randomly started working. Maybe I had a typo in my code.

Sorry for the confusion.