search

godotengine / godot-mono-builds

Mono build scripts for Godot
MIT License
58 stars 43 forks source link

Upgrade build scripts for Mono 6.12 #11

Closed akien-mga closed 3 years ago

akien-mga commented 4 years ago

OS/device including version: Fedora 32 Mono 6.12.0.102 Emscripten 1.39.7 (nominal version supported by Mono 6.12.x)

Issue description: Mono 6.12 has been released (currently 6.12.0.102), and I'm rebuild official containers to use it, based on Fedora 32.

The scripts in this repo will likely need to be updated (as well as the CI) to target Mono 6.12.x and Emscripten 1.39.7.

Current issues I found:

akien-mga commented 4 years ago

Emscripten patching fails, as recent Emscripten no longer write ~/.emscripten. Instead, they expect you to source emsdk_env.sh which sets the PATH, etc.

This makes current CI fail BTW.

akien-mga commented 4 years ago

The current build script is actually OK as the new Emscripten setup does define EM_CONFIG, so as long as env_emsdk.sh has been sourced, it should work.

If we drop support for older Emscripten versions (which we can likely do eventually), most of get_emsdk_root() can be removed to keep only the new os.getenv('EMSDK') (+ validation), and maybe os.getenv('EM_CONFIG') as fallback (which is also defined).

akien-mga commented 3 years ago

As of #15 it seems everything builds fine with Mono 6.12.