Add missing -convcol hint

godotengine / godot-tests

Repository for Godot benchmarks, regression tests, etc.

MIT License

34 stars 33 forks source link

Add missing -convcol hint #13

Closed Shatur closed 3 years ago

Shatur commented 3 years ago

I noticed that -convcol is missing in 32678-respect-import-hints-with-empty.blend.

fire commented 3 years ago

Can you also update the associated files?

blender --background --python blend_export.py

Shatur commented 3 years ago

I tried it before this PR and have a different .fbx files. Maybe because of a different Blender version? I use 2.90.1. Is it okay if I update them with my version of Blender?

fire commented 3 years ago

Use your version. It’s fine. Probably want to log your version in the description.

Shatur commented 3 years ago

Done.

Should I create a separate file for the hints from https://github.com/godotengine/godot/pull/39105? (in another PR, of course).

fire commented 3 years ago

Up to you. There are advantages of seeing the files in the same file and advantages of having a new file.