Closed abaire closed 3 years ago
Hey @fire I started writing some tests for the change to/removal of _sanitize_scene_name
. Does this look like a reasonable start? Once I have a change that passes the basics I plan on adding tests to ensure bones are still properly attached as well.
I'll try to look near the weekend, don't wait for me.
Still a little bit of work to be done, but I think this is ready for a first pass.
Remaining bits:
Animation checking code is fixed, added a skeleton test. Emoji tests still fail without the patch from @bruvzg (as expected), but generate nodes that are referenceable if you know that the emoji chars will be replaced by the replacement chars (I'd propose leaving as is if the improvement to the JSON tokenizer is likely to be accepted).
Is this ready to be merged?
I think so. It looks like I can't add reviewers on this repo though (and there doesn't seem to be an automatically assigned reviewer like on the main repo).
Thanks for contributing to Godot Engine.
Adds automated tests for godotengine/godot#45545