godotengine / godot-visual-script

VisualScript as a Godot Engine c++ module
MIT License
120 stars 22 forks source link

Improve the UX of Visual Scripting Nodes #17

Open swarnimarun opened 5 years ago

swarnimarun commented 5 years ago

List Type Nodes

image

This is a quick MockUp to help understand the idea.

Here the color code is that brighter color is for the Specific Type and then the duller(whitish color) is for the Array of that type.

We have + and x buttons to add and remove elements.

This will make the setter node much more powerful and much less redundant(each setter editing one value was kinda wonky) and we obviously need a create Array node.

This design theme can be followed to other aspects of the Visual Script system as well. Like Getters, Maps and etc.

Probably have even the Curve and Gradient Editors be a part of the Visual Script directly to make editing fields of even resources easier.

For now we can add this as extra type of nodes to allow for backwards compatibility.

swarnimarun commented 5 years ago

cc: @fire

fire commented 5 years ago

@swarnimarun Can you update this with you pr number?

VicentGJ commented 5 years ago

Looks nice, it's a really needed change before doing practically anything else in VS system. For now it looks so bad to the eye, and the differentiation between different kinds of nodes is not clear enough

lentsius-bark commented 5 years ago

Yes please! Making the nodes self sufficient without having to leave them for every change is an awesome UX change.

swarnimarun commented 4 years ago

Here's the commit that does most of the foundational work for the changes, https://github.com/godotengine/godot/pull/29681

Added some of the basic nodes for some of the features mentioned above and some of the UX changes.

I will make another draft of ideas for some of the visual changes, feel free to provide some advice that you might believe would be a better look for VisualScript. Although I am working mostly on features rather than the Theme of the Visual Script itself.

Norrox commented 4 years ago

is this possible to add to the visual shader to? if so then maybe my proposal is not needed ? :P https://github.com/godotengine/godot-proposals/issues/134

swarnimarun commented 4 years ago

@norrox yes it's possible to add similar feature to Visual Shader but it would need to be rewritten and the UI changes still haven't been made.

Gianclgar commented 4 years ago

There are more ideas that could be useful for this at godotengine/godot-proposals#506 and godotengine/godot-proposals#593

Norrox commented 4 years ago

Here's the commit that does most of the foundational work for the changes, godotengine/godot#29681

Added some of the basic nodes for some of the features mentioned above and some of the UX changes.

I will make another draft of ideas for some of the visual changes, feel free to provide some advice that you might believe would be a better look for VisualScript. Although I am working mostly on features rather than the Theme of the Visual Script itself.

I have always felt that Bolt has a nice Visual Script theme. Just to put some ideas here 😊 Bolt5 Messy This os from bolt 2 e568645d-3f63-47f1-9feb-f564b787dcde_Bolt2Mockup