search

godotengine / godot-visual-script

VisualScript as a Godot Engine c++ module
MIT License
121 stars 29 forks source link

Make sure the Visual Script submenus/popups don't open in separate window #28

Open swarnimarun opened 4 years ago

swarnimarun commented 4 years ago

Godot version: master

OS/device including version: all

Issue description: Visual Script submenus/popups open in separate window

image

image

Steps to reproduce: one of the many, Right click on the visual script.

Cause: (I believe it's because) We use AcceptDialogs by default for just about everything in VisualScript. Except some edge cases like right clicking on variables opens a PopupMenu.

ASIDE

Part of godotengine/godot-visual-script#37

cc: @fire am I doing something wrong? Cause otherwise visual script it quite broken at the moment.

I will check to make sure if it's not my mistake anywhere, if not I will start on a fix for it in the morning.

Also not sure but there also seem to be some bugs with the Dialogs that open in new window. Should I actually create bug reports for all of them. Or just submit separate PRs while fixing the visual script stuff?

akien-mga commented 2 years ago

Right click "Add node" in the current master branch gives this dialog, which makes sense as a window I think: image

The rename dialog still shows up as a tiny window, it would be nicer if it could edit in place like in the Scene Tree dock.

Aside from this, dialogs opening as new windows is not a bug, it's expected from multi-window support in the editor. One can use Single Window mode to revert to the behavior in 3.x with embedded popups.

So to me the problem is more than VisualScript might be too dialog heavy if these windows come in the way.

Anutrix commented 2 years ago

Since we removed Visual Scripting in https://github.com/godotengine/godot/pull/64822 from this repo and moved it to https://github.com/godotengine/godot-visual-script, can we start transferring Visual Scripting issues(including this one) to that repo?

Zireael07 commented 2 years ago

@Anutrix Many VS issues were already transferred, so I guess yes?