godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.57k stars 168 forks source link

Fixes for godot 4 scene preview #457

Closed QuinsZouls closed 1 year ago

QuinsZouls commented 1 year ago

This a set of fixes for the scene tree in godot 4 ref: #451 .

What's include?

ddelvall commented 1 year ago

Any news about the update of the plugin?

DaelonSuzuka commented 1 year ago

If there's feedback that's relevant to an open PR, the correct place for that is in the comments of that PR. It's not appropriate to make new PRs that completely contain existing open PRs.

One big reason is that involving the original author of a given PR can help avoid obvious errors, like:

It's unfortunate that this PR was submitted this way, because there were a number of real mistakes in my original code and you fixed several of them. If this feedback had been in the correct place, I'm sure we could have had a productive discussion, I could have learned a lesson about proofreading, and both of us could have avoiding wasting our time with this whole episode.