search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.53k stars 151 forks source link

Settings changes not acknowledged in current unreleased version [41f40ee] #474

Closed sequpt closed 1 year ago

sequpt commented 1 year ago

Godot version

v4.0.2.stable.official (https://github.com/godotengine/godot/commit/7a0977ce2c558fe6219f0a14f8bd4d05aea8f019)

VS Code version

1.77.1

Godot Tools VS Code extension version

1.3.1 [41f40ee]

System information

Linux Debian 11

Issue description

Changing the settings are not acknowledged by the plugin in the current unreleased version [41f40ee] due to the wrong name used as the section-identifier in utils.ts at line 5.

const CONFIG_CONTAINER = "godot-tools";

should be 

const CONFIG_CONTAINER = "godotTools";

The bug seems to have been introduced by commit cdc550a412dfffd26dfe7351e429b73c819d68d0 and only partially fixed by 41f40ee38f5209adc7f00f61c69b7697188a7de0.

Steps to reproduce

  1. Make sure the language server port in the Godot editor isn't the same as the default value expected by the plugin(6008). That is the case for a default v4.0.2.stable.official (https://github.com/godotengine/godot/commit/7a0977ce2c558fe6219f0a14f8bd4d05aea8f019) installation where the port is set to 6005.
  2. Open a Godot project in VSCode
  3. Wait for the plugin to fail to connect to the language server 10 times
  4. Notice the error message: Couldn't connect to the GDScript language server at 127.0.0.1:6008. Is the Godot editor running?
  5. Change the Godot Tools > Lsp: Server Port setting to 6005
  6. Repeat step 2 and 3
  7. Notice the port part of the error message hasn't changed