search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.52k stars 149 forks source link

feat(snippets): add match statement #476

Closed maddawik closed 1 year ago

maddawik commented 1 year ago

Adding the same contribution I did here: https://github.com/rafamadriz/friendly-snippets/pull/300

Calinou commented 1 year ago

Sorry for the late response.

@Mawdac Is there anything that would prevent merging this PR?

maddawik commented 1 year ago

@Calinou No worries, I was just going through my open PR's and realized this snippet is both poorly written and also wrong lol. I need to update it here and fix the already merged one in friendly-snippets.

maddawik commented 1 year ago

Ok, this is fixed so that it reflects the actual match syntax. This should be ready to merge from my perspective @Calinou

maddawik commented 1 year ago

@Calinou feel free to check/merge this when it's convenient, I think it's ready now.

Calinou commented 1 year ago

Thanks! Congratulations for your first merged pull request :tada: