search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.52k stars 149 forks source link

Default language server port doesn't match with Godot 4 (#473) fix + Godot 3 back-compatibility #492

Closed runny-yolk closed 10 months ago

runny-yolk commented 11 months ago

I figured it would be good to update the default for Godot 4 as people seem to get caught up on it fairly frequently (#473), however there's still a lot of v3 users, so as a compromise I've added a fallback port, which it will use when it's used up half of the max connection attempts. I also doubled the number of connection attempts, so both ports get the 10 they were getting before.

By default, the main serverPort is the Godot 4 default, and the fallback is the Godot 3 default.

I tested this code of course, but I haven't developed much for VScode or Godot before, so please scrutinise my code as much as you like.

As an aside, I noticed that the warning message at the top of the README isn't on the VSCode marketplace? Seems like the version published there might be out of date.

DaelonSuzuka commented 10 months ago

Thanks for taking the time to submit this PR. Unfortunately, we won't be able to use it due a large rewrite of the LSP client code that was recently merged.

Additionally, PR #511 implements a solution for the Godot3/4 port issue that I think is more robust.

runny-yolk commented 10 months ago

@DaelonSuzuka Ah, no worries, I'm just happy to see the issue fixed.