Closed ryanabx closed 10 months ago
The new annotation should probably be in a separate PR that depends on https://github.com/godotengine/godot/pull/82987 being merged. The other two seems great for consistency.
The new annotation should probably be in a separate PR that depends on https://github.com/godotengine/godot/pull/82987 being merged.
No, there's no reason to push that out to another PR. Adding and removing annotations is a trivial change, and the linked engine PR seems quite likely to get merged.
The grammar in this extension is explicitly attempting to be a superset of all versions of GDScript, so adding support for future features is just as valid as maintaining support for Godot 3 features or features that were deprecated and removed.
Sorry for the delay. Everything looks fine to me.
@abstract
annotation https://github.com/godotengine/godot/pull/82987 (4.3) to the list of annotations in the gdscript textmate grammar.will move to a new PRnvm.
properties) and are now highlighted properly asvariable.other.property.gdscript
void
as akeyword
instead of aclass
. See https://github.com/godotengine/godot/blob/a574c0296b38d5f786f249b12e6251e562c528cc/modules/gdscript/gdscript_tokenizer.h#L130C4-L130C8 (gdscript considersvoid
to be a keyword, similar to C-style languages)NOTE: This is my first time working with regular expressions, so please let me know if I've made a mistake with my added regular expressions!
Before:
After: