godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.52k stars 149 forks source link

Syntax highlighting changes #515

Closed ryanabx closed 10 months ago

ryanabx commented 10 months ago

NOTE: This is my first time working with regular expressions, so please let me know if I've made a mistake with my added regular expressions!

Before: image

After: image

atirut-w commented 10 months ago

The new annotation should probably be in a separate PR that depends on https://github.com/godotengine/godot/pull/82987 being merged. The other two seems great for consistency.

DaelonSuzuka commented 10 months ago

The new annotation should probably be in a separate PR that depends on https://github.com/godotengine/godot/pull/82987 being merged.

No, there's no reason to push that out to another PR. Adding and removing annotations is a trivial change, and the linked engine PR seems quite likely to get merged.

The grammar in this extension is explicitly attempting to be a superset of all versions of GDScript, so adding support for future features is just as valid as maintaining support for Godot 3 features or features that were deprecated and removed.

DaelonSuzuka commented 10 months ago

Sorry for the delay. Everything looks fine to me.