search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.48k stars 148 forks source link

Adjust Godot version detection regex #526

Closed mlsvrts closed 8 months ago

mlsvrts commented 8 months ago

The previous version detection would fail to detect some versions of godot (e.g 4.1.1.stable.mono.official.bd6af8e0e), resulting in an unclear error message. This commit makes a minor change to slightly improve the robustness of the version detection regex.

With this change I can run and debug my project with godot 4.1.1, and breakpoints even work 😄

DaelonSuzuka commented 8 months ago

Thanks for catching that, and congrats on your first contribution!

mlsvrts commented 8 months ago

Thanks for catching that, and congrats on your first contribution!

No problem! I was very happy to find that, besides this small issue, the debugger upgrade has made Godot 4 debugging integration very painless; thanks for your work on it!

DaelonSuzuka commented 8 months ago

the debugger upgrade has made Godot 4 debugging integration very painless; thanks for your work on it!

That's great to hear! There's more work to do, but it should way more stable and reliable than before.