search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.48k stars 148 forks source link

No .tscn color syntax on master #532

Closed sandygk closed 7 months ago

sandygk commented 7 months ago

Godot version

4.2 beta 3

VS Code version

1.84.2

Godot Tools VS Code extension version

1.3.1 downloaded from (master branch)

System information

windows 11

Issue description

I don't get syntax coloring for my tscn files using the version from the master branch downloaded from the readme. The .gd files are working fine:

image

Steps to reproduce

Open a .tscn with the master's branch version of the extension and notice the lack of color syntax

sandygk commented 7 months ago

It works fine with the version from the VSCode Marketplace

DaelonSuzuka commented 7 months ago

Known issue, already fixed in #529.

sandygk commented 7 months ago

I can confirm the PR indeed fixes the issue:

image

But @DaelonSuzuka, shouldn't we close this issue once the PR is merged instead? Since technically, the issue is still there, and the PR may not even get merged, who knows. It may also prevent other people from opening the same bug issue, since they may check only the open bug issues (as I did) to see if it was already reported

DaelonSuzuka commented 7 months ago

Technically, it would most correct to leave the issue open until the bugfix is released, but I know I'm going to be done with that PR soon(tm), and we'll be publishing the new version shortly after.