godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.48k stars 148 forks source link

Debug current scene: No scene pinned #560

Closed DeszkaCodes closed 6 months ago

DeszkaCodes commented 6 months ago

Godot version

4.2.stable.mono.official

VS Code version

1.85.1

Godot Tools VS Code extension version

2.0.0

System information

Windows 10

Issue description

Cannot debug the pinned scene because the extension cannot find the pinned scene.

Steps to reproduce

  1. Pin a .tscn file in VS Code
  2. Run Godot Tools: Debug Pinned File command
  3. Error saying No pinned scene found appears
DaelonSuzuka commented 6 months ago

This could be my fault. There's two different features called "pin scene". What exactly are you doing to pin your scene?

DeszkaCodes commented 6 months ago

Just the plain old VS Code pinning of a file.

But now I see that there's a custom command to pin the scene. Using this kind of pinning works perfectly.

It is a bit misleading to use the word "pin" given that VS Code also has a pin function.

DaelonSuzuka commented 6 months ago

Honestly I forgot that VSCode even has that. I never use it.

It is a bit misleading to use the word "pin" given that VS Code also has a pin function.

I think it's more unfortunate than misleading. One of them is pinning a scene and the other one is pinning a tab. They're conceptually different.

Plus the Scene Pinning is available in the same place that you'd pin a tab,

image

DeszkaCodes commented 6 months ago

I think maybe it could be called something like "Select as active scene" as Pin could easily be overlooked. Especially if someone is new to Godot Tools or VS Code.

What do you think?

DaelonSuzuka commented 6 months ago

I guess I don't see the problem. Pin Scene File seems perfectly descriptive to me. If you just type "pin" into the command palette you get this:

Code_fTPDkjC6Do

Which says "godot" and "pin" and "scene", that seems like more than enough context.

The VSCode team really should have named their command Pin Tab or something. Just using Pin is bad, greedy behavior on their part.