Prerelease Version on Marketplace

moritztim commented 6 months ago

VS Code version

1.63.0+

Problem statement

I have run into several issues that turned out to be fixed in master. It's a chore to manually reinstalling the extension from dev builds.

Proposed solution

I would love to be able to switch to the pre-release version from within the editor. https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_63.md#pre-release-extensions

Calinou commented 6 months ago

I think we could just release 2.0.0 now. I haven't followed how many breaking changes occurred lately, so maybe releasing it as 1.4.0 is fine if it still works with Godot 3.x.

moritztim commented 6 months ago

@Calinou Sure but that's a separate issue, I still think prerelease versions should be integrated properly, since they're already being released, so it wouldn't be too much effort to also release them to the marketplace

Calinou commented 6 months ago

I still think prerelease versions should be integrated properly, since they're already being released

There are currently no prerelease versions tagged on GitHub, so there are none that could be uploaded on the marketplace.

If @DaelonSuzuka is OK with it, I can tag the current state of the repository as 1.4.0 or 2.0.0 and upload it to the marketplace.

DaelonSuzuka commented 6 months ago

I haven't followed how many breaking changes occurred lately, so maybe releasing it as 1.4.0 is fine if it still works with Godot 3.x.

There are breaking changes from replacing entire sections of the workflow, but everything is still 3.x compatible. I've been aiming at a 2.0.0 release, but I was also trying to resolve some issues people had reported on master. It's possible that I'm aiming too high in terms of expected polish...

If @DaelonSuzuka is OK with it, I can tag the current state of the repository as 1.4.0 or 2.0.0 and upload it to the marketplace.

I think you should do a pre-release now at 1.4.0, but then we should set up publishing via GitHub Actions. I'll message you later and we can talk about the details.

dawsonc623 commented 5 months ago

Do we happen to have an update on a release, or is the best option for getting a newer build to grab the dev build currently?

Calinou commented 5 months ago

Since README.md mentions 2.0.0 already, I guess it makes sense to publish a 2.0.0 next week.

Calinou commented 4 months ago

@DaelonSuzuka I've left you a message on the Godot contributors chat, can you check it?

DaelonSuzuka commented 4 months ago

@Calinou Sorry about that, my login expired and I didn't notice.

Calinou commented 4 months ago

2.0.0 has been released, superseding this issue.

moritztim commented 4 months ago

What about future prerelease versions?

moritztim commented 4 months ago

If that's not planned, close this as "not planned", not as "completed"

DaelonSuzuka commented 4 months ago

close this as "not planned", not as "completed"

Why, for the archeological record? Future historians are going to be very cross with us if we close a GitHub issue "incorrectly"?

What about future prerelease versions?

How can we possibly answer this? If it makes sense at the time, we'll do a pre-release. If it doesn't, we won't.

moritztim commented 4 months ago

Why, for the archeological record?

Yes, think of the future generations. But also so one can quickly see if this issue was completed or not. If I search for an issue about prerelease versions because I can't find them, and see this closed as completed, I think I must be wrong and there is in fact a prerelease version. It's not that important obviously, it's just that there is a simple way to mark the issue correctly, so why not use it.

How can we possibly answer this?

I didn't mean to make you answer it, I'm just saying that this issue is not superseded and should either be closed as "not planned" or left open to be decided on in the future.

Calinou commented 4 months ago

If that's not planned, close this as "not planned", not as "completed"

The way GitHub exposes this to people reading the issue log can be pretty confusing, so I prefer not using the "closing as not planned" functionality. I've had people complain about the exact opposite back when I used it :slightly_smiling_face:

To make things worse, closing as not planned can't be done using the Ctrl + Shift + Enter keyboard shortcut (but closing as completed can).

We aren't opposed to publishing pre-releases in the future if there is a good reason for it (e.g. an experimental feature), but we don't intend to do it right now.

moritztim commented 4 months ago

Yeah GitHub sucks :/

godotengine / godot-vscode-plugin