godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.54k stars 163 forks source link

Improve path handling when starting processes #575

Closed DaelonSuzuka closed 8 months ago

DaelonSuzuka commented 8 months ago

This should resolve #570 and #574.

editorPath.godot3/4 setting and editor_path debug configuration now correctly handle paths with spaces or surrounded with quotes.

The Godot exe version check was missing quotes, so paths with strings were failing the test even thought the actual debugger handles it correctly.

Added validation to the debug config values for address and port to prevent weird, obviously wrong stuff from happening.

Fixed the debug config value editor_path not being used.

Also applied better path handling to "launch godot editor" command.