search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.47k stars 148 forks source link

Fix version check of Godot binary #592

Closed DaelonSuzuka closed 4 months ago

DaelonSuzuka commented 4 months ago

I was using --help to check the version of the specified Godot binary, because it's output is more specific (it includes the words "Godot Engine").

However, Godot 4.3 adds color to the output of --help, and this breaks the regex used to validate the version number.

The extra strictness of using --help is probably overkill, so I'm just switching back to --version.

This PR also changes the default value of godotTools.editorPath.godot4 from godot4 to just godot.

fixes #585