Run and Debug does not kill current instance if asked to stop or restart

godotengine / godot-vscode-plugin

Godot development tools for VSCode

MIT License

1.47k stars 148 forks source link

Run and Debug does not kill current instance if asked to stop or restart #616

Closed enekonieto closed 4 months ago

enekonieto commented 4 months ago

Godot version

3.5.3

VS Code version

1.87.0

Godot Tools VS Code extension version

2.0.0

System information

Kubuntu 22.04

Issue description

While my project/game is running pushing stop in Run/Debug floating panel does not stop it and pushing restart starts a new instance without killing the previous one.

Steps to reproduce

1- Start project/game from VS Code 2A- Push stop in floating panel. Panel disappears but project is still running. 2B- Push restart in floating panel. A new instance is launched without killing previous one.

enekonieto commented 4 months ago

Logs if trying to stop game/project:

2024-03-03 18:22:13.075 [info] Launching game process using command: '"/home/eneko/.local/bin/godot3" --path "/home/eneko/dev/gymkhana/gymkhana" --remote-debug "127.0.0.1:6007"'
2024-03-03 18:22:25.821 [info] Stopping debug controller
2024-03-03 18:22:25.823 [info] Aborting debug controller
2024-03-03 18:22:25.829 [info] Stopping debug controller
2024-03-03 18:22:25.841 [info] Stopping debug controller

enekonieto commented 4 months ago

This is a regression from pre-2.0.0 (I assume I had 1.3.1, but not sure).

DaelonSuzuka commented 4 months ago

Duplicate of #613.

enekonieto commented 4 months ago

Sorry, searched for it but didn't see it, closing.

DaelonSuzuka commented 4 months ago

@enekonieto No worries, I just happen to know that both issues definitely have the same cause.