search

godotengine / godot-website

The code for the official Godot Engine website. A static site built using Jekyll.
https://godotengine.org
MIT License
294 stars 142 forks source link

Make the div an anchor #711

Closed LukeHendrick closed 1 month ago

LukeHendrick commented 12 months ago

Downloaded the engine keyboard only, I was unable to close the modal. Swapped the div out for a button and made it transparent to be a little more accessible

YuriSizov commented 12 months ago

Thanks for opening a PR. I think it should be an anchor then, to match the rest of our buttons and avoid button-specific behavior and styling from browsers.

LukeHendrick commented 12 months ago

Swapped for an anchor!

YuriSizov commented 11 months ago

Sorry for the delay! The layout change seems good to me, but I'm not sure about the added code.

coppolaemilio commented 1 month ago

Superseded by https://github.com/godotengine/godot-website/commit/2167a80780b73ffdcd1910faa83405a1b3e7defb. Thanks for the PR!