godotengine / godot-website

The code for the official Godot Engine website. A static site built using Jekyll.
https://godotengine.org
MIT License
294 stars 148 forks source link

Optimize home page #806

Closed MichaelJRM closed 4 months ago

MichaelJRM commented 7 months ago
Before After
before after
Calinou commented 7 months ago

Created small plugin to fetch CSS asynchronously

I'm concerned this could introduce FOUC (flash of unstyled content). If the CSS isn't available yet, the page will be displayed as raw HTML.

The rest looks good to me :slightly_smiling_face:

MichaelJRM commented 7 months ago

Yes I somehow didn't realize that before, It was only supposed to be used with CSS that's not critical :D

MichaelJRM commented 7 months ago

Fixed a little bug with the fund button, I think I'm done here 🙂

Calinou commented 7 months ago

Changes in this PR cause the homepage font size to change ever so slightly, resulting in line wrapping being broken for the tagline:

Before After (this PR)
image Screenshot_20240221_190614

There's already   between "waiting" and "for", so I don't know what's the cause of this.

Font selection is also different, causing all fonts to be slightly larger on my Linux setup:

Before After (this PR)
image image

Search icon alignment is broken on the Blog page:

Before After (this PR)
image image
MichaelJRM commented 7 months ago

Fixed all but: "Font selection is also different, causing all fonts to be slightly larger on my Linux setup:" Could It be due to the added system-ui font?
What font do you have in your system?

--default-font-family: system-ui, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;

MichaelJRM commented 7 months ago

I've tested on mac and windows and the font looks the same, I think the issue was that before this pr it wasn't picking your system font.

coppolaemilio commented 4 months ago

I'm closing this PR as not planned. While the intentions are good, we are not going to be making significant changes to the current pages before we transition to the new site using hugo. Thanks!