Closed MichaelJRM closed 4 months ago
Before | After |
---|---|
Created small plugin to fetch CSS asynchronously
I'm concerned this could introduce FOUC (flash of unstyled content). If the CSS isn't available yet, the page will be displayed as raw HTML.
The rest looks good to me :slightly_smiling_face:
Yes I somehow didn't realize that before, It was only supposed to be used with CSS that's not critical :D
Fixed a little bug with the fund button, I think I'm done here 🙂
Changes in this PR cause the homepage font size to change ever so slightly, resulting in line wrapping being broken for the tagline:
Before | After (this PR) |
---|---|
There's already
between "waiting" and "for", so I don't know what's the cause of this.
Font selection is also different, causing all fonts to be slightly larger on my Linux setup:
Before | After (this PR) |
---|---|
Search icon alignment is broken on the Blog page:
Before | After (this PR) |
---|---|
Fixed all but: "Font selection is also different, causing all fonts to be slightly larger on my Linux setup:"
Could It be due to the added system-ui font?
What font do you have in your system?
--default-font-family: system-ui, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
I've tested on mac and windows and the font looks the same, I think the issue was that before this pr it wasn't picking your system font.
I'm closing this PR as not planned. While the intentions are good, we are not going to be making significant changes to the current pages before we transition to the new site using hugo. Thanks!