Closed adamscott closed 2 months ago
The download section should be the first thing on the page, you can add the video and the rest of the features afterwards. Most people will come just for the download, and making them scroll should be optional.
I think we can use the hero to highlight an image of a game, something like PVKK instead of having the logo two times. While the monochrome style looks nice, it gets a bit confusing when comparing versions:
The padding in the title is inconsistent, and making the font too big requires for more space for it to not feel too crammed:
The donate button doesn't look like a button, and the background of the godot logos cutting don't look like there is a bug in the site.
There isn't enough contrast in "accent" titles for the cards that have gradient backgrounds, the words "Layer up" are difficult to read:
I'm not sure if mobile was supposed to be in already or if that is something to be added in the future, because it looks incomplete in most of the cases.
I would recommend to split the css into a .scss file (it can be in the same directory).
I would replace the grid-template areas with more generic column layouts and use those names instead of describing the content of them.
grid-template-areas:
/* Header */
"presentation"
"foundation"
"cannot-wait"
"spacer-after-cant-wait"
/* Features: */
"outstanding"
/* Features alphabetically ordered: */
"_2d"
"animation"
"dotnet" /* Should read as "C#". */
"documentation"
"display"
"editor"
"gdscript"
"rendering"
"web"
"xr"
/* Footer */
"spacer-before-download"
"download";
If we were going to reuse this for the base for a future page, we would need to start renaming all the template areas which will be a bit of a mess. So by using agnostic names like span-col-2.
I don't understand the need to make a shadow-root with this much style for each element: Everything that is currently implemented can be achieved with minimal css and standard html. There is a lot of stuff being generated with Javascript without any real need, so I would try to instead of reinventing how to render elements in html I would stick to standards.
Looking at the preview image you kindly put above, I see a typo of "orignially". Also "open source game engine" should be "open-source game engine". Probably more but it's quite hard to read and edit the 4.3.html file, with so much stuff around the blocks of text.
Also, there seems to be a lot of hyphenation where I wouldn't expect it. It looks odd seeing words like "hundreds" or "platform" hyphenated.
I'll look into creating a premultiplied alpha blending demo (most likely a VFX/particles comparison with and without premultiplied alpha).
Edit: I made something, what do you think? It showcases how a premultiplied alpha material can exhibit both additive and mix blending at the same time (while the Mix/Add blend modes can only do one of those at once).
blend_mode_premul_alpha.mp4.zip
Project files: test_3d_premul_alpha.zip
Also, what's the expected aspect ratio for the video?
If we were going to reuse this for the base for a future page, we would need to start renaming all the template areas which will be a bit of a mess.
The grid system was used because it decouples the declaration from the presentation. We need to switch up the order last minute? No problem, we just have to switch it there instead of copy pasting large swaths of code.
If we were going to reuse this for the base for a future page, the categories wouldn't change much, so I'm not worried about this.
I don't understand the need to make a shadow-root with this much style for each element:
This style inside the shadow-root is only repeated there for convenience. It isn't repeated download-wise, "declared once, used multiple times".
I would try to instead of reinventing how to render elements in html I would stick to standards.
With all due respect, this is standard.
With all due respect, this is standard.
Well, if that is a standard we are truly lost in the web front ⚰️🪦
By the way, a new PR will be made, I'm creating a other version based on @coppolaemilio's comments.
Preview of the release page
![image](https://github.com/godotengine/godot-website/assets/270928/747a7771-5257-477a-99b7-76188eedd454)Help needed
I need help to prepare demos for the media. I've done some already, but I need to fill all the media spots that say: "TODO: replace me".
If you plan to create a demo, please comment and say so. It will save some time for everyone.
What I mean by demo
What I mean by demo is a simple project that I can unpack on my machine and capture the content, either with an image or by recording the content. I'll use my Macbook Pro as it has a nice resolution/high DPI.
Demos missing