search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.89k stars 20.16k forks source link

Inconsistent argument names between definition and implementation #15668

Closed Rubonnek closed 6 years ago

Rubonnek commented 6 years ago

Godot version: Master branch commit e141845bfb3e12a9213c8682d5b2589ce5305f70

Issue description:

This is only a style issue for those who like to keep it consistent (like me :stuck_out_tongue_closed_eyes:).

The following were found by cppcheck:

[core/safe_refcount.h:156] -> [core/safe_refcount.cpp:122]: (style, inconclusive) Function 'atomic_conditional_increment' argument 1 names different: declaration 'pw' definition 'counter'.
[core/safe_refcount.h:163] -> [core/safe_refcount.cpp:146]: (style, inconclusive) Function 'atomic_conditional_increment' argument 1 names different: declaration 'pw' definition 'counter'.
[editor/editor_settings.h:148] -> [editor/editor_settings.cpp:996]: (style, inconclusive) Function 'set_initial_value' argument 3 names different: declaration 'update_current' definition 'p_update_current'.
[editor/editor_sub_scene.h:53] -> [editor/editor_sub_scene.cpp:124]: (style, inconclusive) Function '_remove_selection_child' argument 1 names different: declaration 'c' definition 'n'.
[editor/spatial_editor_gizmos.h:108] -> [editor/spatial_editor_gizmos.cpp:302]: (style, inconclusive) Function 'add_solid_box' argument 2 names different: declaration 'size' definition 'p_size'.
[editor/spatial_editor_gizmos.h:379] -> [editor/spatial_editor_gizmos.cpp:2976]: (style, inconclusive) Function 'look_body' argument 1 names different: declaration 'joint_transform' definition 'p_joint_transform'.
[editor/spatial_editor_gizmos.h:379] -> [editor/spatial_editor_gizmos.cpp:2976]: (style, inconclusive) Function 'look_body' argument 2 names different: declaration 'body_transform' definition 'p_body_transform'.
[editor/spatial_editor_gizmos.h:381] -> [editor/spatial_editor_gizmos.cpp:3015]: (style, inconclusive) Function 'look_body_toward_x' argument 1 names different: declaration 'joint_transform' definition 'p_joint_transform'.
[editor/spatial_editor_gizmos.h:381] -> [editor/spatial_editor_gizmos.cpp:3015]: (style, inconclusive) Function 'look_body_toward_x' argument 2 names different: declaration 'body_transform' definition 'p_body_transform'.
[editor/spatial_editor_gizmos.h:382] -> [editor/spatial_editor_gizmos.cpp:3047]: (style, inconclusive) Function 'look_body_toward_y' argument 1 names different: declaration 'joint_transform' definition 'p_joint_transform'.
[editor/spatial_editor_gizmos.h:382] -> [editor/spatial_editor_gizmos.cpp:3047]: (style, inconclusive) Function 'look_body_toward_y' argument 2 names different: declaration 'body_transform' definition 'p_body_transform'.
[editor/spatial_editor_gizmos.h:385] -> [editor/spatial_editor_gizmos.cpp:3079]: (style, inconclusive) Function 'look_body_toward_z' argument 1 names different: declaration 'joint_transform' definition 'p_joint_transform'.
[editor/spatial_editor_gizmos.h:385] -> [editor/spatial_editor_gizmos.cpp:3079]: (style, inconclusive) Function 'look_body_toward_z' argument 2 names different: declaration 'body_transform' definition 'p_body_transform'.
[modules/bullet/bullet_physics_server.h:157] -> [modules/bullet/bullet_physics_server.cpp:374]: (style, inconclusive) Function 'area_get_param' argument 1 names different: declaration 'p_parea' definition 'p_area'.
[modules/bullet/bullet_physics_server.h:304] -> [modules/bullet/bullet_physics_server.cpp:1059]: (style, inconclusive) Function 'joint_create_hinge' argument 2 names different: declaration 'p_frame_A' definition 'p_hinge_A'.
[modules/bullet/bullet_physics_server.h:304] -> [modules/bullet/bullet_physics_server.cpp:1059]: (style, inconclusive) Function 'joint_create_hinge' argument 4 names different: declaration 'p_frame_B' definition 'p_hinge_B'.
[modules/bullet/godot_ray_world_algorithm.h:52] -> [modules/bullet/godot_ray_world_algorithm.cpp:48]: (style, inconclusive) Function 'GodotRayWorldAlgorithm' argument 1 names different: declaration 'm_world' definition 'world'.
[modules/bullet/godot_result_callbacks.h:208] -> [modules/bullet/godot_result_callbacks.cpp:253]: (style, inconclusive) Function 'addContactPoint' argument 2 names different: declaration 'pointInWorld' definition 'pointInWorldOnB'.
[modules/bullet/rigid_body_bullet.h:265] -> [modules/bullet/rigid_body_bullet.cpp:569]: (style, inconclusive) Function 'apply_central_impulse' argument 1 names different: declaration 'p_force' definition 'p_impulse'.
[modules/bullet/rigid_body_bullet.h:270] -> [modules/bullet/rigid_body_bullet.cpp:613]: (style, inconclusive) Function 'apply_torque' argument 1 names different: declaration 'p_force' definition 'p_torque'.
[modules/bullet/shape_bullet.h:102] -> [modules/bullet/shape_bullet.cpp:164]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:119] -> [modules/bullet/shape_bullet.cpp:192]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:136] -> [modules/bullet/shape_bullet.cpp:219]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:155] -> [modules/bullet/shape_bullet.cpp:252]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:172] -> [modules/bullet/shape_bullet.cpp:294]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:190] -> [modules/bullet/shape_bullet.cpp:367]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:209] -> [modules/bullet/shape_bullet.cpp:427]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/shape_bullet.h:225] -> [modules/bullet/shape_bullet.cpp:457]: (style, inconclusive) Function 'create_bt_shape' argument 1 names different: declaration 'p_scale' definition 'p_implicit_scale'.
[modules/bullet/space_bullet.h:78] -> [modules/bullet/space_bullet.cpp:119]: (style, inconclusive) Function 'intersect_shape' argument 4 names different: declaration 'r_results' definition 'p_results'.
[modules/bullet/space_bullet.h:202] -> [modules/bullet/space_bullet.cpp:1023]: (style, inconclusive) Function 'recover_from_penetration' argument 2 names different: declaration 'p_from' definition 'p_body_position'.
[modules/bullet/space_bullet.h:205] -> [modules/bullet/space_bullet.cpp:1092]: (style, inconclusive) Function 'RFP_convex_convex_test' argument 7 names different: declaration 'p_movement_scale' definition 'p_recover_movement_scale'.
[modules/bullet/space_bullet.h:208] -> [modules/bullet/space_bullet.cpp:1123]: (style, inconclusive) Function 'RFP_convex_world_test' argument 9 names different: declaration 'p_movement_scale' definition 'p_recover_movement_scale'.
[modules/gdnative/gdnative_library_editor_plugin.h:82] -> [modules/gdnative/gdnative_library_editor_plugin.cpp:171]: (style, inconclusive) Function '_on_item_collapsed' argument 1 names different: declaration 'item' definition 'p_item'.
[modules/gdnative/pluginscript/pluginscript_script.h:115] -> [modules/gdnative/pluginscript/pluginscript_script.cpp:298]: (style, inconclusive) Function 'get_script_property_list' argument 1 names different: declaration 'r_propertieslist' definition 'r_properties'.
[modules/gridmap/grid_map.h:250] -> [modules/gridmap/grid_map.cpp:387]: (style, inconclusive) Function 'world_to_map' argument 1 names different: declaration 'p_pos' definition 'p_world_pos'.
[modules/mono/csharp_script.h:173] -> [modules/mono/csharp_script.cpp:944]: (style, inconclusive) Function '_ml_call_reversed' argument 2 names different: declaration 'klass' definition 'p_klass'.
[modules/mono/editor/bindings_generator.h:516] -> [modules/mono/editor/bindings_generator.cpp:995]: (style, inconclusive) Function '_generate_cs_property' argument 2 names different: declaration 'p_prop_doc' definition 'p_iprop'.
[modules/mono/editor/bindings_generator.h:523] -> [modules/mono/editor/bindings_generator.cpp:1459]: (style, inconclusive) Function '_save_file' argument 1 names different: declaration 'path' definition 'p_path'.
[modules/mono/editor/bindings_generator.h:523] -> [modules/mono/editor/bindings_generator.cpp:1459]: (style, inconclusive) Function '_save_file' argument 2 names different: declaration 'content' definition 'p_content'.
[modules/mono/editor/bindings_generator.h:506] -> [modules/mono/editor/bindings_generator.cpp:1999]: (style, inconclusive) Function '_default_argument_from_variant' argument 1 names different: declaration 'p_var' definition 'p_val'.
[modules/mono/editor/bindings_generator.h:507] -> [modules/mono/editor/bindings_generator.cpp:2322]: (style, inconclusive) Function '_populate_builtin_type' argument 1 names different: declaration 'r_type' definition 'r_itype'.
[modules/mono/editor/monodevelop_instance.h:46] -> [modules/mono/editor/monodevelop_instance.cpp:55]: (style, inconclusive) Function 'execute' argument 1 names different: declaration 'p_files' definition 'p_file'.
[modules/mono/mono_gd/gd_mono_assembly.h:113] -> [modules/mono/mono_gd/gd_mono_assembly.cpp:241]: (style, inconclusive) Function 'get_class' argument 2 names different: declaration 'p_class' definition 'p_name'.
[modules/mono/mono_gd/gd_mono_class.h:128] -> [modules/mono/mono_gd/gd_mono_class.cpp:300]: (style, inconclusive) Function 'get_method_with_desc' argument 2 names different: declaration 'p_includes_namespace' definition 'p_include_namespace'.
[platform/x11/os_x11.h:202] -> [platform/x11/os_x11.cpp:1538]: (style, inconclusive) Function '_window_changed' argument 1 names different: declaration 'xevent' definition 'event'.
[scene/3d/camera.h:100] -> [scene/3d/camera.cpp:60]: (style, inconclusive) Function '_validate_property' argument 1 names different: declaration 'property' definition 'p_property'.
[scene/resources/animation.h:278] -> [scene/resources/animation.cpp:1606]: (style, inconclusive) Function 'copy_track' argument 1 names different: declaration 'p_track' definition 'src_track'.
[servers/physics/physics_server_sw.h:207] -> [servers/physics/physics_server_sw.cpp:798]: (style, inconclusive) Function 'body_set_axis_lock' argument 3 names different: declaration 'p_lock' definition 'lock'.
[servers/physics_2d_server.h:120] -> [servers/physics_2d_server.cpp:171]: (style, inconclusive) Function 'set_collision_mask' argument 1 names different: declaration 'p_collision_mask' definition 'p_collision_layer'.
[servers/physics_server.h:121] -> [servers/physics_server.cpp:170]: (style, inconclusive) Function 'set_collision_mask' argument 1 names different: declaration 'p_collision_layer' definition 'p_collision_mask'.
[servers/visual/visual_server_scene.h:460] -> [servers/visual/visual_server_scene.cpp:682]: (style, inconclusive) Function 'instance_set_custom_aabb' argument 1 names different: declaration 'p_insatnce' definition 'p_instance'.
[servers/visual/visual_server_scene.h:460] -> [servers/visual/visual_server_scene.cpp:682]: (style, inconclusive) Function 'instance_set_custom_aabb' argument 2 names different: declaration 'aabb' definition 'p_aabb'.
bcr3ative commented 6 years ago

@akien-mga this issue should be closed. I am sorry for not using keywords for closing issues correctly.