search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.06k stars 21.18k forks source link

Duplicated Animation Player loses connection to saved animations #16745

Open PullTheStrings opened 6 years ago

PullTheStrings commented 6 years ago

Godot version:

3.0

OS/device including version:

Issue description:

A duplicated (Ctrl + D) Animation Player loses connection to any saved animations contained in it.

Steps to reproduce: Create a 2D node, add a Sprite and Animation Player as child nodes. Create an animation and save it to disk. Duplicate the 2D node and its children. Now change the animation in the original 2D node and save it. The corresponding animation in the duplicate 2D node Animation Player will not have updated since the connection to the saved animation is now lost.

Minimal reproduction project:

Piet-G commented 6 years ago

Isn't this proper behavior? The animation gets duplicated as well, if you want to have both players share an animation you can just load the old animation in the new player.

vnen commented 6 years ago

Well, in most of the editor resources are shared by default. This might be an inconsistency.

PullTheStrings commented 6 years ago

No it is not proper behaviour. If I have to load in all my animations again in the duplicated animation player to keep the connection to any saved animations, what's the point of duplicating the animation player in the first place.

KoBeWi commented 4 years ago

Still valid in 3.2.2.

This is weird though. The animation is properly shared when you copy-paste it via Animation menu. WHAT'S MORE INTERESTING it is also shared when you use Merge From Scene and copy the node with animation to another scene. Only when you duplicate the node (Ctrl + D) the animation is not shared. It doesn't matter if it's a file or not.

starsidecosmos commented 3 years ago

Still valid in 3.3.2.

Also should be noted that this happens when duplicating an instanced scene. For example, if you duplicate an enemy and then change the properties of an animation in the enemy's parent scene. The changes will only apply to the original instanced enemy scene and not its duplicates (only appears to happen with animation players).

This means you have to reduplicate your enemies every time you want them to have that new animation.

Good news, however. Using copy and paste appears to solve the problem. The animations will be synced across all duplicates according to the parent scene only when they are duplicated using copy and paste and not when they are duplicated using Ctrl + D.

Do with this what you will.