search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.43k stars 20.25k forks source link

ProceduralSky energy doesn't do anything #18856

Closed clayjohn closed 5 years ago

clayjohn commented 6 years ago

Godot version: 3.0.2

Issue description: While documenting the ProceduralSky class I noticed that the properties sun_energy, sky_energy, and ground_energy aren't used anywhere else in the rendering code. I even set up a basic test scene and tried changing them around to see if I was missing something and no matter how the values were set there was no change in the scene. If I changed the background_energy property in the environment then a huge difference was apparent immediately.

Can someone who knows more about the internal renderer confirm this?

creole commented 6 years ago

Just to confirm that these properties don't change anything either when accessed through code, e.g;. environment.background_sky.ground_energy = 0 Godot version 3.0.4

karroffel commented 6 years ago

I think this has little to do with the renderer and more with the generation of the procedural sky that doesn't use them. The renderer doesn't know anything about any procedural skies. All it sees is textures and buffers, there's no special "procedural sky creation" code in the renderer, it's probably somewhere in scene/ as a high-level construct.

clayjohn commented 6 years ago

Your right. It was incorrect to call it rendering code. What i was referring to was sky_box.cpp in scene/resources/ which generates the sky. It has functions and bindings to set and get sky_energy and ground_energy but it doesn't use them anywhere in the generation process. I thought maybe they would appear somewhere in the rendering code but i couldnt find anything.

akien-mga commented 5 years ago

Cherry-picked for 3.0.7.