Condition ' ofs >= p_packet_len ' is true

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine

https://godotengine.org

MIT License

90.71k stars 21.12k forks source link

Condition ' ofs >= p_packet_len ' is true #22175

Closed Nukiloco closed 4 years ago

Nukiloco commented 6 years ago

Godot version:

v3.0.6

OS/device including version:

OS: Windows 10 Graphics Card: Nvidia GTX 750 TI

Issue description:

0:04:13:0143 - Condition ' ofs >= p_packet_len ' is true.
----------
Type:Error
Description: 
Time: 0:04:13:0143
C Error: Condition ' ofs >= p_packet_len ' is true.
C Source: scene/main/scene_tree.cpp:1952
C Function: _network_process_packet

This error randomly appeared when I was working on my multiplayer game. After a few times running my game without making any changes to my code, the error stopped appearing and my game was working again.

Steps to reproduce:

Make a multiplayer game in Godot!
Error randomly appears?

akien-mga commented 6 years ago

CC @godotengine/network

Faless commented 6 years ago

I don't think we have enough information on this. First, did you experience any actual in-game errors? Specifically, that error means a network packet was received, but that packet was invalid. The origin of the packet might not even have been the other Godot client. It might have been some spurious/spoofed packets coming from local network. Additionally, most of the multiplayer code has been moved to MultiplayerAPI in master, does the error happens also with the latest 3.1-alpha?

Nukiloco commented 6 years ago

There was no in-game errors but multiplayer wasn't working when the error was happening in Godot v3.0.6.

akien-mga commented 4 years ago

Is this still reproducible in the current 3.2 builds?

There's not much information to go by in this report, so I'm not sure what we can do to debug further.

Faless commented 4 years ago

I haven't seen anything like this in a long time. Closing as we can't really investigate further, and no other user seems affected.