godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.06k stars 21.18k forks source link

Animation Preview does not work when the process mode is set to Manual #23367

Open telaviv opened 6 years ago

telaviv commented 6 years ago

Godot version:

OS/device including version:

v3.1.alpha.official

Issue description:

When the the animation process mode is in Manual the animation previews don't work.

manual-doesnt-let-you-play

Although it kind of makes sense why it doesn't play from an implementation stand point, from a useability standpoint it's really confusing. If you would want to have a Manual animation then you would have to set it to Idle or Physics when tweaking the animation, then back to Manual when you're done. If this was is intentional there should at least be a ⚠️ to warn the user.

Calinou commented 2 years ago

I can confirm this on master fe95b61e5.

Minimal reproduction project: test_animationplayer_manual.zip

I have a WIP branch to fix this by treating the Manual process mode as Idle within the editor: https://github.com/Calinou/godot/tree/animationplayer-manual-editor-treat-as-idle The same change should likely be applied to AnimationTree as well.

However, I can't test the above branch because of a crash unrelated to this change: https://github.com/godotengine/godot/issues/58960