search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.52k stars 21.26k forks source link

VisualScriptEmitSignal should be replaced by a VisualScriptFunctionCall #28982

Closed Jummit closed 4 years ago

Jummit commented 5 years ago

Godot version: 3.2

Issue description: VisualScriptEmitSignal is useless because its functionality can be replaced by the more flexible VisualScriptFunctionCall.

Steps to reproduce: Create a signal in a VisualScript and drag it into the graph. This creates a VisualScriptEmitSignal, but it could be a VisualScriptFunctionCall.

Xrayez commented 5 years ago

While it might not make sense when done purely via VisualScript, I imagine that other objects could be notified which could as well be extended via GDScript and other script languages where emitting and connecting to signals does make more sense.

mhilbrunner commented 4 years ago

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!