godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.47k stars 20.25k forks source link

Godot cannot find MSBuild.exe with the Visual Studio 2019 Preview #29447

Open Scarjit opened 5 years ago

Scarjit commented 5 years ago

Godot version: v3.1.1 stable mono x64

OS/device including version: Windows 10 Pro 64-bit (10.0.17763) NVIDIA RTX 2080 Ti (Driver Version: 430.86)

Issue description: Godot is unable to find MSBuild, when only using VS 2019 Preview. This issue is closely releated to #27269 The problem occures, because the vswhere executable is executed with -release, but VS 2019 Preview requires -prerelease to be detected.

Steps to reproduce:

  1. Uninstall all Visual Studio versions
  2. Install VS 2019 Preview
  3. Try to run any godot solution, that has an C# script.

Example output

"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -latest -products * -requires Microsoft.Component.MSBuild

->

Visual Studio Locator version 2.6.7+91f4c1d09e [query version 2.1.1046.44959]
Copyright (C) Microsoft Corporation. All rights reserved.
"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -prerelease -products * -requires Microsoft.Component.MSBuild

->

Visual Studio Locator version 2.6.7+91f4c1d09e [query version 2.1.1046.44959]
Copyright (C) Microsoft Corporation. All rights reserved.

instanceId: 2425be05
installDate: 28/05/2019 19:30:23
installationName: VisualStudioPreview/16.2.0-pre.1.0+28917.182
installationPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview
installationVersion: 16.2.28917.182
productId: Microsoft.VisualStudio.Product.Enterprise
productPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\Common7\IDE\devenv.exe
state: 4294967295
isComplete: 1
isLaunchable: 1
isPrerelease: 1
isRebootRequired: 0
displayName: Visual Studio Enterprise 2019
description: Microsoft DevOps solution for productivity and coordination across teams of any size
channelId: VisualStudio.16.Preview
channelUri: https://aka.ms/vs/16/pre/channel
enginePath: C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service
releaseNotes: https://go.microsoft.com/fwlink/?LinkId=660894#16.2.0-pre.1.0
thirdPartyNotices: https://go.microsoft.com/fwlink/?LinkId=660909
updateDate: 2019-05-28T17:30:23.8501785Z
catalog_buildBranch: d16.2
catalog_buildVersion: 16.2.28917.182
catalog_id: VisualStudioPreview/16.2.0-pre.1.0+28917.182
catalog_localBuild: build-lab
catalog_manifestName: VisualStudioPreview
catalog_manifestType: installer
catalog_productDisplayVersion: 16.2.0 Preview 1.0
catalog_productLine: Dev16
catalog_productLineVersion: 2019
catalog_productMilestone: Preview
catalog_productMilestoneIsPreRelease: True
catalog_productName: Visual Studio
catalog_productPatchVersion: 0
catalog_productPreReleaseMilestoneSuffix: 1.0
catalog_productSemanticVersion: 16.2.0-pre.1.0+28917.182
catalog_requiredEngineVersion: 2.2.10.34532
properties_campaignId:
properties_channelManifestId: VisualStudio.16.Preview/16.2.0-pre.1.0+28917.182
properties_nickname:
properties_setupEngineFilePath: C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installershell.exe
Chaosus commented 5 years ago

VS2019 is not in preview state anymore, does it still be a relevant issue ?

Scarjit commented 5 years ago

There is still a preview option, for upcoming patches. The current Live version is 16.1.3 and preview is 16.2.0 Preview 2.0

GoldenQubicle commented 4 years ago

Using VS Community Version 16.5.0 Preview 2.0 and Godot v3.2 this seems to be an issue still. image Though strangely v3.1.1 doesn't have this issue for me.

let4be commented 4 years ago

Same issue on fresh download of godot(first time user), any help? I have Visual Studio 2019 installed on 64bit os