search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.1k stars 21.15k forks source link

Issues with the bezier tracks editor in animationplayer #31783

Open puthre opened 5 years ago

puthre commented 5 years ago

3.1.1.stable.official

Ubuntu 18.04

On a bezier curve track, if you click on the little bezier curve on the right you can now edit the curve. There are however some issues when doing this:

If you select keyframes in it, and try Edit / Scale selection, after you enter a scale ratio, nothing happens. (Also the name is a bit ambiguous in this context as scale can be on the time axis or on the values axis)

If you right click on the tracks list on the left it behaves like it's not there and shows the menu for inserting the keyframes under it.

If you drag the <-> icon right next to "+ Add Track" it will only move the header timeline, you need to scroll so the window will refresh with the updated positions.

If you select the keyframes here, you are no longer able to edit their values from the inspector panel.

Keyframe selection in curve editor is different than the normal keyframe selection. If you select a keyframe then click on the bezier icon, the selection in the bezier editor is the last one you used in the bezier editor not your current keyframe selection.

(Also is there a way to scale the curve vertically? I've copied a bounce track and hoped I could use it for the alpha channel so I needed to scale the values from hundreds to 0..1 interval)

While playing with it I got the following errors in the console

ERROR: _process_operation_list: Error calling method from signal '_clear_selection_for_anim': 'AnimationBezierTrackEdit::_clear_selection_for_anim': Method expected 0 arguments, but called with 1. At: core/undo_redo.cpp:291. ERROR: _process_operation_list: Error calling method from signal '_select_at_anim': 'AnimationBezierTrackEdit::_select_at_anim': Method expected 0 arguments, but called with 3. At: core/undo_redo.cpp:291. ERROR: _get_property_list: Condition ' key == -1 ' is true. At: editor/animation_track_editor.cpp:543.

puthre commented 5 years ago

Also you can't zoom in below -1 -> 1 interval (which you need if you want to model alpha or scale) and no grid lines are shown in this interval so you are kind of guessing what the actual values are.

puthre commented 5 years ago

Seems that most of the issues are fixed in the latest development versions. I've added #31795 for the zoom in and guidelines problem.

puthre commented 5 years ago

I've added #31816 that should also add the values scale feature.

KoBeWi commented 4 years ago

This should be re-evaluated whether it's still valid in Godot 3.2.3 rc6 and then split into multiple issues. Having both bug and enhancement labels makes this issue difficult to track properly.