Open cooperra opened 4 years ago
I've already looked into the code for this and plan to fix it for Hacktoberfest. :jack_o_lantern:
I've already confirmed that disabling adb reverse
functionality fixes the problem in my case. I just need to conditionally disable it for networked adb connections and output a log message.
Can confirm that this bug is present in latest master ( calinou nightly )
Reopening as #32854 is reverted due to the #34376 regression.
Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
@KoBeWi yes, just tried right now.
Installing to device (please wait...): Samsung SM-G900F Performing Push Install C:\Users\User\AppData\Local\Temp/Godot/tmpexport.1620316201.apk: 1 file pushed, 0 skipped. 1.7 MB/s (12554197 bytes in 7.157s) pkg: /data/local/tmp/tmpexport.1620316201.apk Success
--- Device API >= 21; debugging over USB --- --- DEVICE API >= 21; DEBUGGING OVER USB ---
adb.exe: error: more than one device/emulator
Reverse result: 1 Starting: Intent { act=android.intent.action.MAIN cmp=org.godotengine.fantasyworld/com.godot.game.GodotApp }
Is this issue affecting both Godot 3 and 4 or just 3?
Godot version:
master (1fed266bf)
OS/device including version:
Host: Arch Linux, 64bit Android Device: Oculus Quest, 9.0.0
Issue description:
The short version is
adb reverse ...
doesn't work over the network for some reason due to an adb bug and we attempt to use it even if we're connected over the network.The long version is in the steps to reproduce below.
Godot console shows that reverse fails with a non-zero status.
adb reverse
seems to always error withwhen connected wirelessly, even when used outside Godot, and even when there is only one device in
adb devices
.Steps to reproduce:
Attempt to debug a project on an android device over the network (instead of USB).
adb tcpip 5555
adb connect x.x.x.x:5555
(android device's ip)Expected behavior:
Actual behavior:
Minimal reproduction project: N/A
Related to changes in #10792