search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.89k stars 20.15k forks source link

Export Windows: Rightclick on Taskbar icon of exported game says "Godot Engine" #36629

Open golddotasksquestions opened 4 years ago

golddotasksquestions commented 4 years ago

Godot version: 3.2.stable

OS/device including version: Win 64

Issue description: Right clicking on the Taskbar Icon of the exported game says "Godot Engine" instead of the game name. Hovering over the taskbar icon correctly shows the Project Name (as set in the Project Settings), equally correct is the name in the window when the game does not run in fullscreen mode.

Steps to reproduce: Export game to Windows, right click on the taskbar icon.

akien-mga commented 4 years ago

Did you try to change the "Product Name" in the export preset (requires rcedit like for the icon: https://docs.godotengine.org/en/3.2/getting_started/workflow/export/changing_application_icon_for_windows.html)?

golddotasksquestions commented 4 years ago

Yes I did that too. Also pointed the rcedit path. Icon shows up in the taskbar without problem.

golddotasksquestions commented 4 years ago

So after a restart (not just Godot, but my computer), I tested the exported project again, turns out "Godot Engine" is now gone, instead what shows up is the File Description I set in the Windows Export Settings under Application. I would expect the Project Name that was set in the Project Settings.

akien-mga commented 4 years ago

The information you've viewing with a right click on the taskbar icon is determined by the Windows PE file format, it's not for us to define.

If it shows the FileDescription field (which is one of the available strings, see section "string names" in https://docs.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource#remarks), then it's the one you need to set to customize this field.

The default FileDescription value is indeed "Godot Engine", it's hardcoded in the binary by the Windows Resource file (platform/windows/godot_res.rc) and that's why rcedit is necessary to change it.

golddotasksquestions commented 4 years ago

Thanks for the info! Is FileDescription then the right name for this field? Every other software I run just shows the software name when I rightclick the taskbar icon.

If it says "File Description", someone who would want to export to Windows but did not know about what you just explained, would most likely feel inclined to write more than the name of the project, maybe even a small paragraph.

akien-mga commented 4 years ago

Yeah it's a bad name but that's the Windows API, we can't change it.

This could be clarified in tooltips, but we don't have a convenient system to add descriptions to export preset properties for now (contrarily to Project Settings).

So in the meantime this should be documented in the Export docs: https://docs.godotengine.org/en/3.2/getting_started/workflow/export/index.html

golddotasksquestions commented 4 years ago

I am of course aware that the Godot team does not work for Microsoft ;) What I meant is the wording as it appears in the Godot Engine.

export_description

Or are those auto generated from the application api?

akien-mga commented 4 years ago

That's the name of the Microsoft string. It would be wrong that we change it as it would then be harder for users to know what it corresponds to. You can find documentation online on how Windows handles it's PE data "File Description", but not for any custom name we might chose that fits a particular use of this field in Windows 10 taskbar right click.

KoBeWi commented 3 years ago

Any screenshot where it's bugged? I can't reproduce it in 3.2.4 beta4.