godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
89.94k stars 21.06k forks source link

Animation Player Track Editor not zoomable with Trackpad #38237

Open sean256 opened 4 years ago

sean256 commented 4 years ago

Godot version: 3.2.1 stable

OS/device including version: macOS 10.15.4 Magic Trackpad 2

Issue description: Using the trackpad I am unable to zoom/scale the Animation Player Track editor for bezier curves

Steps to reproduce: Use a trackpad and try your best to zoom the bezier track editor. With a mouse you would use the mouse wheel while hovering over the track area, yet with a track pad the scroll gesture does nothing, neither does any gesture that I can think of trying.

Minimal reproduction project: Not project specific, it's an editor thing

Screen Shot 2020-04-26 at 10 38 31 AM

KoBeWi commented 4 years ago

I checked with my regular laptop touchpad and zooming works fine. Can you test in other areas, e.g. 2D editor?

sean256 commented 4 years ago

@KoBeWi It works in the 2D editor. Are you using a Mac trackpad?

sean256 commented 4 years ago

@KoBeWi I should clarify, the gesture to zoom in the 2D editor is different, it's the "pinch and zoom" thing. 2 fingers scrolling in the 2D editor does pan, which is expected.

KoBeWi commented 4 years ago

Are you using a Mac trackpad?

No, I have Asus.

I should clarify, the gesture to zoom in the 2D editor is different, it's the "pinch and zoom" thing

Yes, and it works in both editors for me. Although in the Bezier Editor it works different from mouse wheel. qtCFfA7jq9 Mouse wheel zooms the view, while pinch/zoom gesture scales the timeline.

Calinou commented 4 years ago

I presume this is yet another issue related to high-precision scrolling on macOS.

eduardonunesp commented 4 years ago

Is there any implementation before that using high precision scrolling, I can take a look to give a shot on this one

dploeger commented 4 years ago

I can confirm that. I can't even pan in the bezier editor with my trackpad. It happens both on the internal MacBook trackpad and the magic trackpad. When I use an external trackball (or mouse, I guess), it works.

In the animation editor itself, only vertical scrolling is possible.

ArdaE commented 4 years ago

Same problem here on a MacBook Pro trackpad. None of the following work in the Bezier curve editor:

Note that all of the above work fine in the text editor (for vertical panning, horizontal panning, and font-size adjustment, respectively).

External mouse wheel does work in the Bezier editor (achieves vertical zoom when used on its own, and horizontal zoom when used with the Command key). I haven't figured out a direct way to vertically pan using either the mouse or the trackpad, but because the zoom operations are centred about the mouse cursor, I'm able to indirectly pan by focusing the cursor at the right spots while I zoom in and out with the mouse wheel. Cumbersome, but works if one has a mouse with them.

xaqbr commented 3 years ago

Has there been any fix yet for zooming in the bezier editor for MacBook trackpads? Can there at least be a menu option for it in the meantime??

Calinou commented 3 years ago

Has there been any fix yet for zooming in the bezier editor for MacBook trackpads?

Not yet.

Can there at least be a menu option for it in the meantime??

Maybe, but this needs to be requested in the Godot proposals repository instead of here :slightly_smiling_face:

That said, I think it would be better to have keyboard shortcuts for zooming instead of menu options.

iamjoeysox commented 3 years ago

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

Calinou commented 3 years ago

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

Nobody has started working on this feature, but keep in mind touchpad gestures are only implemented on macOS: https://github.com/godotengine/godot/issues/13139

Therefore, you won't be able to test this on other platforms.

iamjoeysox commented 3 years ago

Any progress on this? I would be willing to help out if someone can point me in the right direction. Thanks!

Nobody has started working on this feature, but keep in mind touchpad gestures are only implemented on macOS: https://github.com/godotengine/godot/issues/13139

Therefore, you won't be able to test this on other platforms.

That's okay I primarily use Mac anyways. I have been looking for something small to start with on learning how to contribute to the engine and this might be a great start. Will look into this when I get some free time. Thanks again!

odbol commented 3 years ago

Just a suggestion: instead of trying to fix the trackpad, it might make more sense to add a separate affordance for changing the scale here, like using a keyboard or a button or something. Not everyone can use a mouse so it's good to have keyboard alternatives for accessibility.

PabloNeirotti commented 1 year ago

This affects macs Magic Mouse too. Touch gestures would be nice but supporting scrolling would be fine. Anything really! The code editor supports scrolling with Apple’s mouse.

andzejsp commented 1 year ago

Windows 10 here, mouse. The issue is still in 4.1.1. I cant zoom the vertical axis. I want to be able to see values from 0 - 10 but by default there is only 0 - 50. doing CTRL + mouse wheel will zoom horizontally, doing CTRL + ALT + mouse wheel will do the same. No vertical zoom. In older versions in tutorials people was able to zoom vertically in bezier curve editor in animation player.

https://github.com/godotengine/godot/assets/80409979/db5325e8-6070-49db-b7f2-ed9852af6b95

EDIT:

Well it turns out if it aint workin, you gotta click inside the curve editor and it will work. See bellow. Very unintuitive

https://github.com/godotengine/godot/assets/80409979/6deaff86-e17e-468f-80d0-a5ff254f3823

artvel commented 9 months ago

Windows 11 + Mac M3 14.2.1 here. Scrolling vertical axis does work in 4.2.1.stable but you need to hold cntrl+alt while scrolling.