search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.71k stars 20.12k forks source link

Shader Graph - Deleting a node in the node editor auto-selects and auto-moves another node. #4433

Closed Ace-Dragon closed 7 years ago

Ace-Dragon commented 8 years ago

Operating system or device: Win10 64 bit; 24 gigs RAM; third-gen i7 CPU; ATI HD 7xxx GPU

Issue description (what happened, and what was expected): When deleting a node in the visual node editor, the editor will often auto-grab another node and move it with the cursor. This is not desired and noticeably impacts usability.

Steps to reproduce: Open the example file, open the node tree for the material, select a node, delete the node. Notice how another one automatically sticks to your cursor for no apparent reason.

Link to minimal example project (optional but very welcome): Bugs.zip

magpie514 commented 8 years ago

You mean the visual shader editor? I've gotten this issue before as well, but I wasn't able to replicate consistently. I can now, though.

mattiascibien commented 8 years ago

I actually replicated this using lastest master. When clicking on the x the second time you delete a node you get the node attached to the left in dragging mode.

vnen commented 8 years ago

I cannot reproduce this issue.

djrm commented 8 years ago

i am also unable to reproduce this one maybe it was fixed with #5308

akien-mga commented 8 years ago

Closing then.

rgrams commented 8 years ago

@akien-mga This bug is alive and well in 2.1 RC2 (Win 64)

shadergraph delete node issue

It doesn't happen if you delete the node by pressing the delete key, just if you click the x.

It affects the visual scripting nodes too of course.

neikeq commented 8 years ago

I can reproduce this too. It doesn't always happens, you must try it multiple times. At least in my case. It also happens after adding new nodes.

vnen commented 8 years ago

I also noticed this when playing with the visual scripting.

magpie514 commented 8 years ago

I noticed it almost immediately when trying out the visual scripting thingy as well.

bojidar-bg commented 8 years ago

Confirmed in the same circumstances.

akien-mga commented 8 years ago

Can't check now, but I'm pretty sure we've got one or two recent duplicates of this issue.

neikeq commented 8 years ago

@akien-mga I found #3568

bojidar-bg commented 8 years ago

I found https://github.com/godotengine/godot/issues/4869

Megalomaniak commented 8 years ago

This issue has existed for me since shadergraph was first introduced. I don't think theres been 1 build I've used where this wasn't an issue.

At this point I only delete graph-nodes with del key and then click on the backdrop before doing anything else automatically since deleting with the del key doesn't 'pick up' the other nodes that get selected but it still selects some other nodes, I think it might do so according to some sort of history of nodes added to the graph. I've noticed that when I deleted 2 nodes together it picked up 2 other nodes after deletion.

akien-mga commented 7 years ago

I can't seem to reproduce anymore in the master branch, it might have been fixed while work was being done on the visual script editor. Can anyone confirm?

volzhs commented 7 years ago

I can reproduce in current master head. A random node is selected when adding, deleting nodes in Shader graph editor. And also, strange random selection happens when changing b value with Scalar+Vector Operator