search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.95k stars 21.15k forks source link

Texture settings test failure in glTF2 import #44553

Open fire opened 3 years ago

fire commented 3 years ago

Godot version: c2e0c6cc2282669017707596c810cde996414131 fork. Should probably test on master.

OS/device including version: win10, nvidia, Vulkan

Issue description:

Test doesn't match.

texture settings

image

Steps to reproduce: Load gltf and compare screenshots.

Minimal reproduction project: https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/TextureSettingsTest

lyuma commented 1 year ago

We need to revisit this. The test results probably changed since 2020 given the way the new texture sampler system works.

lyuma commented 1 year ago

Current results. image

I believe these are a result of engine limitations. Godot no longer supports per-axis repeat settings or mirrored repeats because all textures use shared sampler objects.

As a result, we cannot fully support the glTF spec without creating custom shader code for each case.

Calinou commented 1 year ago

Godot no longer supports per-axis repeat settings or mirrored repeats because all textures use shared sampler objects.

Per-axis repeat was never supported in Godot, but mirrored repeat was supported in 3D in 3.x.