godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
87.04k stars 19.54k forks source link

Vulkan: LightmapGI Bounce Indirect Energy property not implemented (unlike BakedLightmap in `3.x`) #50938

Closed Calinou closed 3 months ago

Calinou commented 2 years ago

Godot version

4.0.dev (7bd7b8f5e)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 465.31)

Issue description

This issue is a reminder to implement https://github.com/godotengine/godot/pull/50827 in the master branch's GPU lightmapper.

If you are reading this and want to give it a try, feel free to open a pull request to reimplement it :slightly_smiling_face: Just leave a comment to let other people know, or to ask questions about the implementation.

Remember that this property should affect indirect lighting energy (bounced light) only. It should not affect direct light (when the light's bake mode is set to All) and emissive materials' lighting.

Steps to reproduce

Minimal reproduction project

N/A

BlueCube3310 commented 3 months ago

Fixed by #82068, I think this should be closed to avoid cluttering the tracker.