Can't remove or reduce painted weights in Polygon2D UV-editor

bluepandion commented 3 years ago

Godot version

3.3.2 stable

System information

Windows 10

Issue description

I mistakenly reported this as a bug before because I thought bone weights could not be removed.

Since I don't know how to remove this issue, I'll just report my user experience here:

Painted bone weights on my Polygon2D
Tried to remove weights but couldn't figure out how
Used both Paint Bucket tool and Brush tool but they didn't seem to have any effect no matter what value I set in the slider
Wondering if the slider is an absolute value or like an opacity value
Finally hovered long enough over Brush icon to see that it's actually a removal tool
Brush/Removal tool still feels like it works on some clicks and other clicks it doesn't

TLDR; Maybe the brush icon could be an eraser icon instead - The bucket should look like a brush, since that's how it behaves.

Steps to reproduce

Make a Polygon2D and a Skeleton2D with some bones.
Assign skeleton to Polygon2D
Paint bone weights to vertices
Try to find a way to remove painted weights

Minimal reproduction project

No response

Calinou commented 3 years ago

Someone can implement erasing by clicking with the right mouse button to address this. The eraser tool will remain available in situations where right-clicking a lot is not viable.

aXu-AP commented 1 year ago

I would like to implement right-click to erase, but the input handling of the uv editor is structured quite funkily. The structure might have made sense when there weren't multiple modes in one editor, but now it's hard to navigate and add features like this. Here's how it's now (pseudocode):

if left mouse:
  if pressed
    if this mode:
      if that tool:
        do something
    // other modes and tools
  else:
    if this mode:
      if that tool:
        do something
    // other modes and tools
else if right mouse:
  cancel
  if this mode:
    do extra step

It would make sense to rearrange the code by different modes. Hacking it in with various if clauses is also possible, but I find it distasteful to make the code flow even worse. I'll add this to my refactor wishlist (godotengine/godot-proposals#8209).

As for the issue at hand, I think the source of confusion is poor choice of icons. Seeing a bucket and a brush makes one think about fill and paint tools (moreso in this context). Even if that brush is used elsewhere in the editor as "clear", I didn't make the connection until checking the source for the name of the icon. I suggest using Edit and Eraser icons (I can make a pr if this looks good):

godotengine / godot