search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
88.68k stars 20.11k forks source link

`join` function is missing from PoolStringArray in GDNative headers #53116

Closed API-Beast closed 2 years ago

API-Beast commented 4 years ago

In GDScript there is a "join" function to take a PoolStringArray and a delimiter and turn it into a String.

https://docs.godotengine.org/en/3.1/classes/class_poolstringarray.html#class-poolstringarray-method-join

This function is missing in the headers.

BastiaanOlij commented 2 years ago

This issue needs to be raised in Godot itself as the source implementation lies there, there indeed does not seem to be an implementation for join.

akien-mga commented 2 years ago

I transferred the issue to the Godot repo.

PoolVector's join is defined here in the 3.x branch for the core API: https://github.com/godotengine/godot/blob/3.x/core/pool_vector.h#L434-L443

But indeed it's not implemented in the GDNative headers (modules/gdnative/include/gdnative/pool_arrays.h).

I'm not familiar enough with the new GDExtensions yet to say if this affects master too.

kdiduk commented 2 years ago

I can make a fix for 3.x and a back-port for 3.4

Calinou commented 2 years ago

I can make a fix for 3.x and a back-port for 3.4

Feel free to open a pull request for this :slightly_smiling_face:

You probably only need to open one pull request against 3.x, then we can cherry-pick the commit to 3.4.

akien-mga commented 2 years ago

Fixed by #55826.