search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
90.78k stars 21.13k forks source link

ConcavePolygonShape3D and ConvexPolygonShape3D are meshes not polygons, maybe they should be renamed? #53426

Open Arnklit opened 3 years ago

Arnklit commented 3 years ago

Godot version

4.0

System information

Windows 10, GLES3, GTX 980Ti

Issue description

Since ConcavePolygonShape3D, ConvexPolygonShape3D are meshes, it seems a mistake and confusing to call them polygons. I suggest renaming them, since a lot of renaming is happening in 4.0 anyway. Let me know if this should be a proposal instead.

Steps to reproduce

NA

Minimal reproduction project

NA

Xrayez commented 3 years ago

Not sure about 3D, but in 2D it's basically the same. Those names suggest intention rather than what they represent. "Concave" polygons are meant to be built via individual segments, while "convex" are built from individual convex polygons (at least in 2D). Both "concave" and "convex" polygon shapes can be either concave or convex, it mostly boils down to how they are decomposed into meshes at the end of the day.

But yes, I'd say the current design is unfortunate.

Calinou commented 3 years ago

We could rename "Concave" to "Trimesh" to be in accordance with the MeshInstance collision generation options.