Open m21-cerutti opened 2 years ago
have verified that Visual Studio have installed Window SDK 10, and all the recommendation from the documentation.
MinGW do not use Windows SDK or Visual Studio in any way.
I have also gcc that is in the PATH (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0
GCC version is irrelevant, but GCC 8.x is 4 years old and might be shipped with the old MinGW headers 6.0.0.
ENABLE_VIRTUAL_TERMINAL_PROCESSING
should be available in the MinGW headers 7.0.0+ (current version is 9.0.0).
Sorry i made a mistake, it was the MingW version that is 8.0.1.
ENABLE_VIRTUAL_TERMINAL_PROCESSING
should be available in the MinGW headers 7.0.0+ (current version is 9.0.0).
I can confirm, here's the commit which added it: https://github.com/mirror/mingw-w64/commit/1b29d1bc58910a4c21ff2c5c804bf06821032348 It's included in 7.0.0 onwards.
Sorry i made a mistake, it was the MingW version that is 8.0.1.
Does adding #include <wincon.h>
in platform/windows/os_windows.cpp
fix it for you?
If not, can you check if your MinGW's sys-root/mingw/include/wincon.h
has a definition for ENABLE_VIRTUAL_TERMINAL_PROCESSING
?
Does adding #include
Including windows.h
should be enough, but I guess WIN32_LEAN_AND_MEAN
might work differently on MinGW and MSVC, include it should not cause any issues on both. Probably we can add the header directly.
Thanks for your response, adding wincon.h
or windows.h
have not worked, and for Mingw i have maybe a begining of answer.
My wincon.h is was in C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\x86_64-w64-mingw32\include
, and doesn't contain a definition for ENABLE_VIRTUAL_TERMINAL_PROCESSING
.
Since it appears suspect i have reinstalled mingw64 with now with this configuration from https://sourceforge.net/projects/mingw-w64/
But no definition again for ENABLE_VIRTUAL_TERMINAL_PROCESSING
.
I think for this problem it's because i don't have build from the sources of mingw but it seems weird.
https://sourceforge.net/projects/mingw-w64/ Source: README.rst, updated 2018-05-24
There are recent files in this repo, but the installer seems to be outdated (if it's from 2018, most likely it is MinGW v6.0.0 or v5.0.4 with GCC 8.1.0). There's no MinGW 8.1.0 release at all - see https://www.mingw-w64.org/changelog/
I would suggest using https://www.msys2.org/ to install MinGW.
Ok seems it has solve the problem. Thanks you !
Maybe it would be nice to add it to the documentation ? Maybe some kind of verification or warning about the MingW version needed like for the posix
thread model ?
Don’t know if it is linked, as we don’t use mingwin, but we experience same error on latest windows GitHub runner: https://github.com/utopia-rise/godot-kotlin-jvm/runs/5588451500?check_suite_focus=true
Don’t know if it is linked, as we don’t use mingwin
From this log, it's clear that it is using MinGW. Even if you have not specified use_mingw
for the scons it will use it if MinGW is found and Visual Studio is not.
Don’t know if it is linked, as we don’t use mingwin
From this log, it's clear that it is using MinGW. Even if you have not specified
use_mingw
for the scons it will use it if MinGW is found and Visual Studio is not.
Oh thanks ! Never noticed the using mingwin log on our jobs.
EDIT: here is a previous log on our side: https://github.com/utopia-rise/godot-kotlin-jvm/runs/4828315772?check_suite_focus=true It was using MSVC as default. So it seems default behaviour on GitHub runners has changed. This won’t cause trouble to this repo CI ?
@bruvzg Is there a predefined macro that can tell the version of the mingw headers?
@bruvzg Is there a predefined macro that can tell the version of the mingw headers?
#if defined(__MINGW64_VERSION_MAJOR) && __MINGW64_VERSION_MAJOR >= 7
Godot version
3.4.3-stable
System information
Windows 10 / MINGW 8.1.0 / Intel Core i7-8700 AMD64
Issue description
When trying to compile with MINGW from sources, there is an error during the process. I have verified that Visual Studio have installed Window SDK 10, and all the recommendation from the documentation. I have also gcc that is in the PATH (x86_64-posix-seh-rev0, Built by MinGW-W64 project) 8.1.0
The error:
Steps to reproduce
Try to compile with my configuration and this script :
Minimal reproduction project
No response